New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641451 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Refactor stream selection for seeking in FFmpegDemuxer

Project Member Reported by servolk@chromium.org, Aug 26 2016

Issue description

The current logic is not taking into account that streams can be
disabled and is heavily tied to the assumption of max 1 audio/video
stream. This refactoring strives to preserve the original logic as
much as possible, but also disregards disabled streams when searching
for the preferred seeking stream, and generalizes that logic to
potentially handle multiple audio/video streams.
 
Labels: OS-All
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed5b4e1fde34046c1f5365b30ff3b4bee7fbc4b4

commit ed5b4e1fde34046c1f5365b30ff3b4bee7fbc4b4
Author: servolk <servolk@chromium.org>
Date: Fri Aug 26 22:38:26 2016

Refactor stream selection for seeking in FFmpegDemuxer

The current logic is not taking into account that streams can be
disabled and is heavily tied to the assumption of max 1 audio/video
stream. This refactoring strives to preserve the original logic as
much as possible, but also disregards disabled streams when searching
for the preferred seeking stream, and generalizes that logic to
potentially handle multiple audio/video streams.

BUG= 641451 

Review-Url: https://codereview.chromium.org/2281843002
Cr-Commit-Position: refs/heads/master@{#414836}

[modify] https://crrev.com/ed5b4e1fde34046c1f5365b30ff3b4bee7fbc4b4/media/filters/ffmpeg_demuxer.cc
[modify] https://crrev.com/ed5b4e1fde34046c1f5365b30ff3b4bee7fbc4b4/media/filters/ffmpeg_demuxer.h
[modify] https://crrev.com/ed5b4e1fde34046c1f5365b30ff3b4bee7fbc4b4/media/filters/ffmpeg_demuxer_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment