Password extensions don't work for patreon.com login |
|||||||||
Issue description[as reported by evankroske@ here: b/30121829] Steps to reproduce: 1. Go to https://www.patreon.com/login. 2. Use password manager extension, such as 1Password, to fill out log in form. Expected: Username and password are filled out. Actual: Username and password fields remain blank. It's not a 1Password bug: https://discussions.agilebits.com/discussion/comment/316658#Comment_316658
,
Oct 1 2016
,
Oct 1 2016
,
Oct 30 2016
The <head> element in www.patreon.com/login contains this: <base href="/"> This throws off the login form recognizer to treat https://www.patreon.com/login (derived from the form) as not equal to https://www.patreon.com (derived from the base url). So, the password filler did not process the form with the username and password.
,
Oct 31 2016
,
Nov 1 2016
,
Dec 22 2016
Sorry for taking so long to have a look at this.
#4 is correct. This is caused by obsolete code in password_controller.js, __gCrWeb.getPasswordFormData:
...
'action': formElement.getAttribute('action'),
...
The non-iOS counterpart is password_form_conversion_utils.cc, CreatePasswordFormFromWebForm [1]:
password_form->action = form_util::GetCanonicalActionForForm(web_form);
While it is possible to fix it, we are actually planning a major refactoring, which will move password_form_conversion_utils.cc to browser. After that, iOS code will share the desktop code (which works well with patreon.com).
Therefore I will keep this one open, and we can revisit it once the refactoring happens.
[1] https://cs.chromium.org/chromium/src/components/autofill/content/renderer/password_form_conversion_utils.cc?cl=GROK&gsn=GetCanonicalActionForForm&rcl=1482380380&l=660
,
Jun 1 2017
Issue 726461 has been merged into this issue.
,
Jun 4 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by pkl@chromium.org
, Aug 29 2016Owner: pkl@chromium.org
Status: Assigned (was: Untriaged)