New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 641411 link

Starred by 1 user
Status: Fixed
Owner:
dougarnett@chromium.org
Closed: Aug 2016
Cc:
█ dim...@chromium.org
fgor...@chromium.org
petewil@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Offline Pages] Kick Coordinator to start processing upon a Pause/Resume if network is available

Project Member Reported by dougarnett@chromium.org, Aug 26 2016 
To improve background loading responsiveness for Downloads (over the more passive GcmNetworkManager scheduling), we should consider explicitly starting processing upon a Pause or Resume action if the network is connected.

This is a follow up idea to starting processing when a user request is added and network in avavailable (landed in patch 2279913002).

Comment 2 by dim...@chromium.org, Aug 29 2016 

Please merge as this causes bad UX (stuck download) after testing.

Comment 3 by dim...@chromium.org, Aug 29 2016

Status: Assigned (was: Untriaged)

Comment 4 by dougarnett@chromium.org, Aug 29 2016

Labels: Merge-Request-54

Comment 5 by dimu@chromium.org, Aug 29 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)

Comment 6 by dougarnett@chromium.org, Aug 29 2016

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a89fe90688136d490c68381c6dab2e81db3c9f46

commit a89fe90688136d490c68381c6dab2e81db3c9f46
Author: Pete Williamson <petewil@chromium.org>
Date: Tue Aug 30 18:26:42 2016

[OfflinePages] Resuming a SavePageRequest now may start processing if network is connected.

BUG= 641411 

Review-Url: https://codereview.chromium.org/2282973003
Cr-Commit-Position: refs/heads/master@{#414887}
(cherry picked from commit f8c26a79f6b7b886787f6f611c3fa9c302b42abf)

Review URL: https://codereview.chromium.org/2298433002 .

Cr-Commit-Position: refs/branch-heads/2840@{#52}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/a89fe90688136d490c68381c6dab2e81db3c9f46/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/a89fe90688136d490c68381c6dab2e81db3c9f46/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/a89fe90688136d490c68381c6dab2e81db3c9f46/components/offline_pages/background/request_coordinator_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a89fe90688136d490c68381c6dab2e81db3c9f46

commit a89fe90688136d490c68381c6dab2e81db3c9f46
Author: Pete Williamson <petewil@chromium.org>
Date: Tue Aug 30 18:26:42 2016

[OfflinePages] Resuming a SavePageRequest now may start processing if network is connected.

BUG= 641411 

Review-Url: https://codereview.chromium.org/2282973003
Cr-Commit-Position: refs/heads/master@{#414887}
(cherry picked from commit f8c26a79f6b7b886787f6f611c3fa9c302b42abf)

Review URL: https://codereview.chromium.org/2298433002 .

Cr-Commit-Position: refs/branch-heads/2840@{#52}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/a89fe90688136d490c68381c6dab2e81db3c9f46/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/a89fe90688136d490c68381c6dab2e81db3c9f46/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/a89fe90688136d490c68381c6dab2e81db3c9f46/components/offline_pages/background/request_coordinator_unittest.cc
►

Sign in to add a comment