VR: Transitions - Place phone in headset |
||||||||||||||||||
Issue descriptionDescription: When clank is running and the user inserts the phone into the headset, the app transitions into VR mode. * Fire a VRDisplayEvent to any potential webvr content. The content has an option of calling requestPresent if it wants to go full screen. * If requestPresent wasn't called, and the current window is full screen, transition into "cinema mode" * otherwise, transition into standard/single window mode. TBD: UX for Animations and transition effects (timing, fade in, animations) TBD: other events may need to be fired into the doc (window resize, orientation change) TBD: video content should be paused during the transition (covered under issue 641397)
,
Sep 2 2016
The second bullet is covered in issue 643495.
,
Sep 2 2016
,
Sep 2 2016
,
Sep 6 2016
For fullscreen content like games, we may also want to fire visibilitychange and make the tab inactive during transition.
,
Oct 11 2016
,
Oct 11 2016
,
Oct 12 2016
,
Oct 12 2016
,
Oct 17 2016
,
Oct 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1754d506140c20ef7f263d75eff24a58a60398ed commit 1754d506140c20ef7f263d75eff24a58a60398ed Author: bshe <bshe@chromium.org> Date: Mon Oct 24 14:47:19 2016 Launch Chrome when phone inserted into Daydream headset IFF Chrome was the active app This is implemented by using Daydream Api. After a headset is detected by phone, instead of launch Daydream Home app, ChromeVR is launched iff Chrome was the foreground app. Follow up CLs will trigger auto presentation if VR aware content was showing. BUG= 641401 Review-Url: https://codereview.chromium.org/2428563003 Cr-Commit-Position: refs/heads/master@{#427070} [modify] https://crrev.com/1754d506140c20ef7f263d75eff24a58a60398ed/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [add] https://crrev.com/1754d506140c20ef7f263d75eff24a58a60398ed/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java [add] https://crrev.com/1754d506140c20ef7f263d75eff24a58a60398ed/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java [modify] https://crrev.com/1754d506140c20ef7f263d75eff24a58a60398ed/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/1754d506140c20ef7f263d75eff24a58a60398ed/chrome/android/java_sources.gni
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dca762297c5f26cb188075775d571c00702d77a4 commit dca762297c5f26cb188075775d571c00702d77a4 Author: mthiesse <mthiesse@chromium.org> Date: Thu Nov 17 05:49:22 2016 Fix placing phone in headset exiting VR. Currently, daydream DON flow can be passed without putting the phone in the headset (rotating to landscape and pairing the controller passes the DON flow). At the same time, because we don't integrate with daydream home, and we're not a separate activity, we exit VR any time we're paused. This leads to a situation where we're in VR without having the headset on, we put the phone into the headset, the NFC trigger fires and launches the NFC handling activity (which immediately exits because we're in VR), which causes us to pause and exit VR. There's no way at the moment to detect that we're returning from the NFC activity, short of hacks around listening to the NFC trigger ourselves. This CL adds a timeout for re-entering VR on CTA resume, after a CTA pause, that should be short enough to avoid any user interaction intending to exit VR leading them to re-enter it. BUG= 641401 Review-Url: https://codereview.chromium.org/2510713003 Cr-Commit-Position: refs/heads/master@{#432773} [modify] https://crrev.com/dca762297c5f26cb188075775d571c00702d77a4/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c34e2fa914fb0f72599f632c3168f9ec3884441f commit c34e2fa914fb0f72599f632c3168f9ec3884441f Author: mthiesse <mthiesse@chromium.org> Date: Fri Nov 18 16:13:13 2016 Implement vrdisplayactivate for GVR DON. This allows webVR pages to auto-present when the DON flow is triggered by putting the phone in the headset, rather than by the page requesting WebVR. BUG= 641401 Review-Url: https://codereview.chromium.org/2502363004 Cr-Commit-Position: refs/heads/master@{#433213} [modify] https://crrev.com/c34e2fa914fb0f72599f632c3168f9ec3884441f/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/c34e2fa914fb0f72599f632c3168f9ec3884441f/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/c34e2fa914fb0f72599f632c3168f9ec3884441f/chrome/browser/android/vr_shell/vr_shell_delegate.h [modify] https://crrev.com/c34e2fa914fb0f72599f632c3168f9ec3884441f/device/vr/android/gvr/gvr_delegate.h [modify] https://crrev.com/c34e2fa914fb0f72599f632c3168f9ec3884441f/device/vr/android/gvr/gvr_device_provider.cc [modify] https://crrev.com/c34e2fa914fb0f72599f632c3168f9ec3884441f/device/vr/android/gvr/gvr_device_provider.h
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ebc409e6f3e818512ebd0231cf9222e5d9400d3 commit 4ebc409e6f3e818512ebd0231cf9222e5d9400d3 Author: mthiesse <mthiesse@chromium.org> Date: Fri Nov 18 16:19:22 2016 Be more selective about when we show the "Take off your headset" flow. BUG= 641401 Review-Url: https://codereview.chromium.org/2516453002 Cr-Commit-Position: refs/heads/master@{#433214} [modify] https://crrev.com/4ebc409e6f3e818512ebd0231cf9222e5d9400d3/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Nov 18 2016
Marking this as Fixed. Any missing flows (like cinema mode) are covered in other bugs. Any bugs in the implemented flows can also be covered in new bugs.
,
Nov 19 2016
https://chromium.googlesource.com/chromium/src.git/+/c34e2fa914fb0f72599f632c3168f9ec3884441f and https://chromium.googlesource.com/chromium/src.git/+/4ebc409e6f3e818512ebd0231cf9222e5d9400d3 missed the M56 branch point and we would like to merge them in to ensure this feature works in it's entirety.
,
Nov 19 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 23 2016
Reopen for merge tracking.
,
Nov 28 2016
,
Nov 28 2016
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ce07cc452c18c78e717feaadb20b7a1b8359ca5 commit 3ce07cc452c18c78e717feaadb20b7a1b8359ca5 Author: bshe <bshe@chromium.org> Date: Wed Nov 30 17:36:55 2016 Implement vrdisplayactivate for GVR DON. This allows webVR pages to auto-present when the DON flow is triggered by putting the phone in the headset, rather than by the page requesting WebVR. BUG= 641401 Review-Url: https://codereview.chromium.org/2502363004 Cr-Commit-Position: refs/heads/master@{#433213} (cherry picked from commit c34e2fa914fb0f72599f632c3168f9ec3884441f) Review URL: https://codereview.chromium.org/2538053003 . Cr-Commit-Position: refs/branch-heads/2924@{#193} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/3ce07cc452c18c78e717feaadb20b7a1b8359ca5/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/3ce07cc452c18c78e717feaadb20b7a1b8359ca5/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/3ce07cc452c18c78e717feaadb20b7a1b8359ca5/chrome/browser/android/vr_shell/vr_shell_delegate.h [modify] https://crrev.com/3ce07cc452c18c78e717feaadb20b7a1b8359ca5/device/vr/android/gvr/gvr_delegate.h [modify] https://crrev.com/3ce07cc452c18c78e717feaadb20b7a1b8359ca5/device/vr/android/gvr/gvr_device_provider.cc [modify] https://crrev.com/3ce07cc452c18c78e717feaadb20b7a1b8359ca5/device/vr/android/gvr/gvr_device_provider.h
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ce07cc452c18c78e717feaadb20b7a1b8359ca5 commit 3ce07cc452c18c78e717feaadb20b7a1b8359ca5 Author: bshe <bshe@chromium.org> Date: Wed Nov 30 17:36:55 2016 Implement vrdisplayactivate for GVR DON. This allows webVR pages to auto-present when the DON flow is triggered by putting the phone in the headset, rather than by the page requesting WebVR. BUG= 641401 Review-Url: https://codereview.chromium.org/2502363004 Cr-Commit-Position: refs/heads/master@{#433213} (cherry picked from commit c34e2fa914fb0f72599f632c3168f9ec3884441f) Review URL: https://codereview.chromium.org/2538053003 . Cr-Commit-Position: refs/branch-heads/2924@{#193} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/3ce07cc452c18c78e717feaadb20b7a1b8359ca5/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/3ce07cc452c18c78e717feaadb20b7a1b8359ca5/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/3ce07cc452c18c78e717feaadb20b7a1b8359ca5/chrome/browser/android/vr_shell/vr_shell_delegate.h [modify] https://crrev.com/3ce07cc452c18c78e717feaadb20b7a1b8359ca5/device/vr/android/gvr/gvr_delegate.h [modify] https://crrev.com/3ce07cc452c18c78e717feaadb20b7a1b8359ca5/device/vr/android/gvr/gvr_device_provider.cc [modify] https://crrev.com/3ce07cc452c18c78e717feaadb20b7a1b8359ca5/device/vr/android/gvr/gvr_device_provider.h
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe9528356a709e285a417aa6221c07b722c18baa commit fe9528356a709e285a417aa6221c07b722c18baa Author: bshe <bshe@chromium.org> Date: Wed Nov 30 18:43:14 2016 Be more selective about when we show the "Take off your headset" flow. BUG= 641401 Review-Url: https://codereview.chromium.org/2516453002 Cr-Commit-Position: refs/heads/master@{#433214} (cherry picked from commit 4ebc409e6f3e818512ebd0231cf9222e5d9400d3) Review URL: https://codereview.chromium.org/2540223002 . Cr-Commit-Position: refs/branch-heads/2924@{#199} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/fe9528356a709e285a417aa6221c07b722c18baa/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Nov 30 2016
,
Jul 4
|
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by ddorwin@chromium.org
, Sep 2 2016