New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 641393 link

Starred by 1 user
Status: Fixed
Owner:
█ dim...@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
█ dim...@chromium.org
fgor...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Download button is enabled for offline pages

Project Member Reported by dewittj@chromium.org, Aug 26 2016 
Version: ToT @ dca0b3af9cef28d4fdb953e3b83bbe94a7671df6 (crrev.com/414734)

OS: Android N, Nexus 7

What steps will reproduce the problem?
(1) Ensure device is online
(2) Navigate to a site (e.g. reddit.com)
(3) Click the download button
(4) Go offline
(5) Open downloads home
(6) Open offline page for reddit.com
(7) Click download button

What do you see?
Download Starting toast
Error notification "Download failed" with a file:// URL.

What did you expect to see?
Maybe no download button available?
screenshot-070c55b9-20160826T102659.png
479 KB View Download

Comment 1 by dim...@chromium.org, Aug 29 2016

Owner: dim...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34c37ca4817eb0331a06bf14cd2ffc58af8b2013

commit 34c37ca4817eb0331a06bf14cd2ffc58af8b2013
Author: Dmitry Titov <dimich@chromium.org>
Date: Wed Aug 31 20:24:19 2016

Disable Download button if current tab is showing offline page already, or an error or interstitial.

BUG= 641391 , 641393 

Review-Url: https://codereview.chromium.org/2296603004
Cr-Commit-Position: refs/heads/master@{#415691}
(cherry picked from commit ef9788fc36a0a6dbc16c20b9c1c63529c9bb027e)

Review URL: https://codereview.chromium.org/2297933003 .

Cr-Commit-Position: refs/branch-heads/2840@{#78}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/34c37ca4817eb0331a06bf14cd2ffc58af8b2013/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/34c37ca4817eb0331a06bf14cd2ffc58af8b2013/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java

Comment 4 by dewittj@chromium.org, Sep 23 2016

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34c37ca4817eb0331a06bf14cd2ffc58af8b2013

commit 34c37ca4817eb0331a06bf14cd2ffc58af8b2013
Author: Dmitry Titov <dimich@chromium.org>
Date: Wed Aug 31 20:24:19 2016

Disable Download button if current tab is showing offline page already, or an error or interstitial.

BUG= 641391 , 641393 

Review-Url: https://codereview.chromium.org/2296603004
Cr-Commit-Position: refs/heads/master@{#415691}
(cherry picked from commit ef9788fc36a0a6dbc16c20b9c1c63529c9bb027e)

Review URL: https://codereview.chromium.org/2297933003 .

Cr-Commit-Position: refs/branch-heads/2840@{#78}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/34c37ca4817eb0331a06bf14cd2ffc58af8b2013/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/34c37ca4817eb0331a06bf14cd2ffc58af8b2013/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
►

Sign in to add a comment