Able to "download" the offline error page |
|||||
Issue descriptionVersion: ToT @ dca0b3af9cef28d4fdb953e3b83bbe94a7671df6 (crrev.com/414734) OS: Android N, Nexus 7 What steps will reproduce the problem? (1) Go into airplane mode (2) Navigate to a site (e.g. reddit.com) (3) Click the download button What is the expected output? Scheduled a download for when online What do you see instead? Saved the error page Please use labels and text to provide additional information.
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef9788fc36a0a6dbc16c20b9c1c63529c9bb027e commit ef9788fc36a0a6dbc16c20b9c1c63529c9bb027e Author: dimich <dimich@chromium.org> Date: Wed Aug 31 18:35:07 2016 Disable Download button if current tab is showing offline page already, or an error or interstitial. BUG= 641391 , 641393 Review-Url: https://codereview.chromium.org/2296603004 Cr-Commit-Position: refs/heads/master@{#415691} [modify] https://crrev.com/ef9788fc36a0a6dbc16c20b9c1c63529c9bb027e/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java [modify] https://crrev.com/ef9788fc36a0a6dbc16c20b9c1c63529c9bb027e/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
,
Aug 31 2016
,
Aug 31 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34c37ca4817eb0331a06bf14cd2ffc58af8b2013 commit 34c37ca4817eb0331a06bf14cd2ffc58af8b2013 Author: Dmitry Titov <dimich@chromium.org> Date: Wed Aug 31 20:24:19 2016 Disable Download button if current tab is showing offline page already, or an error or interstitial. BUG= 641391 , 641393 Review-Url: https://codereview.chromium.org/2296603004 Cr-Commit-Position: refs/heads/master@{#415691} (cherry picked from commit ef9788fc36a0a6dbc16c20b9c1c63529c9bb027e) Review URL: https://codereview.chromium.org/2297933003 . Cr-Commit-Position: refs/branch-heads/2840@{#78} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/34c37ca4817eb0331a06bf14cd2ffc58af8b2013/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java [modify] https://crrev.com/34c37ca4817eb0331a06bf14cd2ffc58af8b2013/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
,
Sep 1 2016
Verified in M54-54.0.2840.8 download button is disabled on offline page/an error/interstitial
,
Sep 7 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34c37ca4817eb0331a06bf14cd2ffc58af8b2013 commit 34c37ca4817eb0331a06bf14cd2ffc58af8b2013 Author: Dmitry Titov <dimich@chromium.org> Date: Wed Aug 31 20:24:19 2016 Disable Download button if current tab is showing offline page already, or an error or interstitial. BUG= 641391 , 641393 Review-Url: https://codereview.chromium.org/2296603004 Cr-Commit-Position: refs/heads/master@{#415691} (cherry picked from commit ef9788fc36a0a6dbc16c20b9c1c63529c9bb027e) Review URL: https://codereview.chromium.org/2297933003 . Cr-Commit-Position: refs/branch-heads/2840@{#78} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/34c37ca4817eb0331a06bf14cd2ffc58af8b2013/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java [modify] https://crrev.com/34c37ca4817eb0331a06bf14cd2ffc58af8b2013/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dim...@chromium.org
, Aug 29 2016Status: Assigned (was: Untriaged)