Completion of page download issues duplicate success notifications |
|||||||
Issue descriptionCompletion of page download issues duplicate success notifications (With async loading enabled) 1. Open any page 2. Long press on any link and select "save linked page for later" 3. Wait for notification to show download success Expected: A single notification for this page download being a success Actual: Duplicate notifications
,
Aug 26 2016
I'll quickly debug our end of issuing notifications, to see if maybe we post this one twice.
,
Aug 26 2016
It does happen on our end. Taking this over.
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36bb3dc904af1b642b516515780ce137b4806c34 commit 36bb3dc904af1b642b516515780ce137b4806c34 Author: fgorski <fgorski@chromium.org> Date: Fri Aug 26 20:08:50 2016 [Offline pages] Eliminating duplicate notifications, by fixing request queue store * Successfully removed requests where returned in result as duplicates * above was fixed with tests updated BUG= 641380 R=dewittj@chromium.org Review-Url: https://codereview.chromium.org/2283813003 Cr-Commit-Position: refs/heads/master@{#414790} [modify] https://crrev.com/36bb3dc904af1b642b516515780ce137b4806c34/components/offline_pages/background/request_queue_store_sql.cc [modify] https://crrev.com/36bb3dc904af1b642b516515780ce137b4806c34/components/offline_pages/background/request_queue_store_unittest.cc
,
Aug 26 2016
For testers: alternative way to trigger is to download a page that hasn't loaded yet.
,
Aug 29 2016
,
Aug 29 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Aug 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae2738c3da44a1a83632f0df6d127c99dfb386cb commit ae2738c3da44a1a83632f0df6d127c99dfb386cb Author: Filip Gorski <fgorski@chromium.org> Date: Mon Aug 29 16:59:18 2016 [Offline pages] Eliminating duplicate notifications, by fixing request queue store * Successfully removed requests where returned in result as duplicates * above was fixed with tests updated BUG= 641380 R=petewil@chromium.org Review-Url: https://codereview.chromium.org/2283813003 Cr-Commit-Position: refs/heads/master@{#414790} (cherry picked from commit 36bb3dc904af1b642b516515780ce137b4806c34) Review URL: https://codereview.chromium.org/2286403002 . Cr-Commit-Position: refs/branch-heads/2840@{#17} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/ae2738c3da44a1a83632f0df6d127c99dfb386cb/components/offline_pages/background/request_queue_store_sql.cc [modify] https://crrev.com/ae2738c3da44a1a83632f0df6d127c99dfb386cb/components/offline_pages/background/request_queue_store_unittest.cc
,
Sep 17 2016
Verified Fixed in 55.0.2862.0
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae2738c3da44a1a83632f0df6d127c99dfb386cb commit ae2738c3da44a1a83632f0df6d127c99dfb386cb Author: Filip Gorski <fgorski@chromium.org> Date: Mon Aug 29 16:59:18 2016 [Offline pages] Eliminating duplicate notifications, by fixing request queue store * Successfully removed requests where returned in result as duplicates * above was fixed with tests updated BUG= 641380 R=petewil@chromium.org Review-Url: https://codereview.chromium.org/2283813003 Cr-Commit-Position: refs/heads/master@{#414790} (cherry picked from commit 36bb3dc904af1b642b516515780ce137b4806c34) Review URL: https://codereview.chromium.org/2286403002 . Cr-Commit-Position: refs/branch-heads/2840@{#17} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/ae2738c3da44a1a83632f0df6d127c99dfb386cb/components/offline_pages/background/request_queue_store_sql.cc [modify] https://crrev.com/ae2738c3da44a1a83632f0df6d127c99dfb386cb/components/offline_pages/background/request_queue_store_unittest.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by qin...@chromium.org
, Aug 26 2016