New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 641378 link

Starred by 2 users
Status: WontFix
Owner:
bokan@chromium.org
Closed: Nov 2016
Cc:
pdr@chromium.org
rbyers@chromium.org
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 236262


Sign in to add a comment

Investigate/Fix Viewport UMA counters with SVG

Project Member Reported by bokan@chromium.org, Aug 26 2016 
It turns out SVG images get their own Page (and thus VisualViewport) and report that they're in the main Frame for the page. This means we're reporting UMA counters for embedded SVG images as if they were the whole page. This is likely skewing our Viewport statistics since an embedded SVG image won't have viewport meta tags, user zoom, etc.

We should figure out how our assumptions are violated by SVGs and fix the issue so that we don't count embedded SVGs as a full page. (Though it's debatable if an SVG document loaded directly should count).

Comment 1 by bokan@chromium.org, Sep 1 2016

Cc: pdr@chromium.org rbyers@chromium.org
It turns out this metric is fine on the SVG-front for an incidental reason. We weren't reporting for anything that wasn't in the HTTP family of protocols and it seems that embedded SVGs always get loaded with an "about:blank" URL (pdr@, correct me if I'm wrong) so we wouldn't report for them. The only way I see the metric getting used for SVG is if we load the SVG file directly.

In that case, I think we probably want to report viewport metrics only for HTML and XHTML documents but I don't think SVG is responsible for our mysterious dip of '15.

Comment 2 by pdr@chromium.org, Sep 2 2016

Cc: chrishtr@chromium.org
We do indeed load svg images with a blank url.

Just to double-check, the HTTP/HTTPS restriction is only for the VisualViewport-specific counters using the protocolIsInHTTPFamily check in VisualViewport.cpp?

Comment 3 by pdr@chromium.org, Sep 2 2016

Cc: -chrishtr@chromium.org
Oops, -chrishtr

Comment 4 by bokan@chromium.org, Sep 2 2016 

The stat that we care more about and that I was looking into is the "MetaTagType" which is in ViewportDescription::reportMobilePageStats, but yes, we have that check there as well. And yes, I believe that check is specific to the viewport/pinch counters.

Comment 5 by pdr@chromium.org, Sep 2 2016 

Cool, I think we can close this as WONTFIX.

@rbyers, do you have a bug for the larger fix for the SVG UseCounter data?

Comment 6 by lafo...@chromium.org, Sep 17 2016

Components: -Metrics Internals>Metrics

Comment 7 by bokan@chromium.org, Nov 26 2016

Status: WontFix (was: Assigned)

Comment 8 by rbyers@chromium.org, Nov 28 2016

Blockedon: 236262
 Issue 236262  is probably the main bug that track's the work I'm doing here.
►

Sign in to add a comment