New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641377 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Status Tray too small on login screen

Project Member Reported by kuscher@chromium.org, Aug 26 2016

Issue description

Chrome Version       : 54.0.2837.0
OS Version: 8739.0.0

The status tray is too small on the login screen. It seems to not follow the right sizing anymore. Compare to in-session.
 
Not seeing on minnie running canary (8743.0.0), what device did you see this on?
Pixel 2. You need to reboot fully. Upon logout it looks fine oddly enough.
Screenshot?
Okay finally was able to track this one down. Two screenshots from Minnie, note the size difference. It is even more pronounced on Samus.
Screenshot 2016-09-08 at 10.54.59 AM.png
855 KB View Download
Screenshot 2016-09-08 at 10.46.08 AM.png
840 KB View Download
Cc: yoshiki@chromium.org
+yoshiki@ who has worked on notifications recently
yoshiki@ are you the right person to tackle this one?
Cc: zalcorn@chromium.org
Owner: yoshi@chromium.org
Status: Started (was: Assigned)
This is because the tray on login screen doesn't have an avatar icon. Let me fix this.

Comment 8 by yoshi@chromium.org, Sep 28 2016

Owner: yoshiki@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b94365f59e52eace812d71d97c2469d68caac9c3

commit b94365f59e52eace812d71d97c2469d68caac9c3
Author: yoshiki <yoshiki@chromium.org>
Date: Thu Sep 29 09:41:57 2016

The height of the status tray should be 37px, but it wasn't on login and lock screen. This patch fixes it.

Major changes:
1) Sets the minimum height 37px (kTrayItemSize actually)
2) Removes the vertical margin of web notification tray. this is no longer necessary thanks to #1.
3) Removes the hack for win in ShelfLayoutManagerTest::StatusAreaHitBoxCoversEdge.

BUG= 641377 
TEST=see the notification tray manually with MD and non-MD mode

Review-Url: https://codereview.chromium.org/2369293002
Cr-Commit-Position: refs/heads/master@{#421790}

[modify] https://crrev.com/b94365f59e52eace812d71d97c2469d68caac9c3/ash/common/system/tray/tray_background_view.cc
[modify] https://crrev.com/b94365f59e52eace812d71d97c2469d68caac9c3/ash/common/system/tray/tray_background_view.h
[modify] https://crrev.com/b94365f59e52eace812d71d97c2469d68caac9c3/ash/common/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/b94365f59e52eace812d71d97c2469d68caac9c3/ash/shelf/shelf_layout_manager_unittest.cc

Second patch, to match the heights of the status bars: https://codereview.chromium.org/2371153002/
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9699d3ee0cea558cb2f71669240355cbc9d723a3

commit 9699d3ee0cea558cb2f71669240355cbc9d723a3
Author: yoshiki <yoshiki@chromium.org>
Date: Thu Oct 06 07:01:17 2016

Set status bar height to 44px on login screen

The height of the status bar is 44px on normal screen, but is 48px on login and lock screen. This patch makes the login screen 44px, by reducing 3px black bottom border and 1px top margin. As the result, the height of top and bottom margin and tray are same among login, lock and normal screen.

BUG= 641377 
TEST=see the notification tray manually with MD and non-MD mode

Review-Url: https://codereview.chromium.org/2371153002
Cr-Commit-Position: refs/heads/master@{#423461}

[modify] https://crrev.com/9699d3ee0cea558cb2f71669240355cbc9d723a3/chrome/browser/resources/chromeos/login/header_bar.css

Labels: Merge-Request-54
I think it's not high priority for M54, but good to have.

Comment 13 by dimu@chromium.org, Oct 11 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.
Labels: -M-54 -Hotlist-Merge-review M-55 Merge-Request-55
I don't think it's urgent for M54. Let me change the milestone.

Comment 15 by dimu@chromium.org, Oct 20 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 16 by sheriffbot@chromium.org, Oct 23 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Review-54 -Merge-Approved-55
Status: Fixed (was: Started)
Both patch are in the M55, since they are committed before the branch point.
Status: Verified (was: Fixed)
Verified on ChromeOS 8872.25.0, 55.0.2883.28 minnie
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9699d3ee0cea558cb2f71669240355cbc9d723a3

commit 9699d3ee0cea558cb2f71669240355cbc9d723a3
Author: yoshiki <yoshiki@chromium.org>
Date: Thu Oct 06 07:01:17 2016

Set status bar height to 44px on login screen

The height of the status bar is 44px on normal screen, but is 48px on login and lock screen. This patch makes the login screen 44px, by reducing 3px black bottom border and 1px top margin. As the result, the height of top and bottom margin and tray are same among login, lock and normal screen.

BUG= 641377 
TEST=see the notification tray manually with MD and non-MD mode

Review-Url: https://codereview.chromium.org/2371153002
Cr-Commit-Position: refs/heads/master@{#423461}

[modify] https://crrev.com/9699d3ee0cea558cb2f71669240355cbc9d723a3/chrome/browser/resources/chromeos/login/header_bar.css

Comment 20 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment