One setting button on opt-in IME menu |
|||||||||
Issue descriptionOS: <ChromeOS> When there's only one settings button on the opt-in IME menu, it shows one gear icon center aligned. Attached 'current_ime_menu.png'. Suggested by UI reviewer, it's better to make the gear icon left-aligned with text 'Language and input settings'. Attached 'expected_ime_menu.png'.
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bc89ebf6173622a65c685f633a0c35911d153b4 commit 6bc89ebf6173622a65c685f633a0c35911d153b4 Author: azurewei <azurewei@chromium.org> Date: Fri Aug 26 22:56:56 2016 Change UI of settings button on IME menu: When there's only one button, we show the gear icon with text. Otherwise, just show the icon directly. BUG= 641300 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2287453002 Cr-Commit-Position: refs/heads/master@{#414848} [modify] https://crrev.com/6bc89ebf6173622a65c685f633a0c35911d153b4/ash/ash_chromeos_strings.grdp [modify] https://crrev.com/6bc89ebf6173622a65c685f633a0c35911d153b4/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acbd0c3b500bdd3de1dff36e2d5f771f1413ca96 commit acbd0c3b500bdd3de1dff36e2d5f771f1413ca96 Author: azurewei <azurewei@chromium.org> Date: Tue Aug 30 05:45:38 2016 Based on UI reviewer's comments, the setting button on opt-in IME menu should be update as only text when there's only one button. BUG= 641300 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2287953002 Cr-Commit-Position: refs/heads/master@{#415176} [modify] https://crrev.com/acbd0c3b500bdd3de1dff36e2d5f771f1413ca96/ash/ash_chromeos_strings.grdp [modify] https://crrev.com/acbd0c3b500bdd3de1dff36e2d5f771f1413ca96/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
,
Aug 30 2016
,
Aug 30 2016
,
Aug 31 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba40e0a3d5127775630f413bfbfae1cbef302ffe commit ba40e0a3d5127775630f413bfbfae1cbef302ffe Author: azurewei <azurewei@chromium.org> Date: Wed Aug 31 05:35:41 2016 Change UI of settings button on IME menu: When there's only one button, we show the gear icon with text. Otherwise, just show the icon directly. TBR=jamescook@chromium.org NOPRESUBMIT=true NOTRY=true BUG= 641300 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2287453002 Cr-Commit-Position: refs/heads/master@{#414848} (cherry picked from commit 6bc89ebf6173622a65c685f633a0c35911d153b4) Review-Url: https://codereview.chromium.org/2293373003 Cr-Commit-Position: refs/branch-heads/2840@{#60} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/ba40e0a3d5127775630f413bfbfae1cbef302ffe/ash/ash_chromeos_strings.grdp [modify] https://crrev.com/ba40e0a3d5127775630f413bfbfae1cbef302ffe/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/747c873cc05742d82d59bc4cdbe7c502467f6a0f commit 747c873cc05742d82d59bc4cdbe7c502467f6a0f Author: azurewei <azurewei@chromium.org> Date: Wed Aug 31 05:42:48 2016 Update the UI of setting button on IME menu Based on UI reviewer's comments, the setting button on opt-in IME menu should be update as only text when there's only one button. TBR=jamescook@chromium.org NOPRESUBMIT=true NOTRY=true BUG= 641300 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2287953002 Cr-Commit-Position: refs/heads/master@{#415176} (cherry picked from commit acbd0c3b500bdd3de1dff36e2d5f771f1413ca96) Review-Url: https://codereview.chromium.org/2297853004 Cr-Commit-Position: refs/branch-heads/2840@{#61} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/747c873cc05742d82d59bc4cdbe7c502467f6a0f/ash/ash_chromeos_strings.grdp [modify] https://crrev.com/747c873cc05742d82d59bc4cdbe7c502467f6a0f/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
,
Oct 7 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba40e0a3d5127775630f413bfbfae1cbef302ffe commit ba40e0a3d5127775630f413bfbfae1cbef302ffe Author: azurewei <azurewei@chromium.org> Date: Wed Aug 31 05:35:41 2016 Change UI of settings button on IME menu: When there's only one button, we show the gear icon with text. Otherwise, just show the icon directly. TBR=jamescook@chromium.org NOPRESUBMIT=true NOTRY=true BUG= 641300 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2287453002 Cr-Commit-Position: refs/heads/master@{#414848} (cherry picked from commit 6bc89ebf6173622a65c685f633a0c35911d153b4) Review-Url: https://codereview.chromium.org/2293373003 Cr-Commit-Position: refs/branch-heads/2840@{#60} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/ba40e0a3d5127775630f413bfbfae1cbef302ffe/ash/ash_chromeos_strings.grdp [modify] https://crrev.com/ba40e0a3d5127775630f413bfbfae1cbef302ffe/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/747c873cc05742d82d59bc4cdbe7c502467f6a0f commit 747c873cc05742d82d59bc4cdbe7c502467f6a0f Author: azurewei <azurewei@chromium.org> Date: Wed Aug 31 05:42:48 2016 Update the UI of setting button on IME menu Based on UI reviewer's comments, the setting button on opt-in IME menu should be update as only text when there's only one button. TBR=jamescook@chromium.org NOPRESUBMIT=true NOTRY=true BUG= 641300 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2287953002 Cr-Commit-Position: refs/heads/master@{#415176} (cherry picked from commit acbd0c3b500bdd3de1dff36e2d5f771f1413ca96) Review-Url: https://codereview.chromium.org/2297853004 Cr-Commit-Position: refs/branch-heads/2840@{#61} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/747c873cc05742d82d59bc4cdbe7c502467f6a0f/ash/ash_chromeos_strings.grdp [modify] https://crrev.com/747c873cc05742d82d59bc4cdbe7c502467f6a0f/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
,
Nov 19 2016
,
Jan 21 2017
,
Feb 6 2017
Chrome 57.0.2987.30/9202.17.0 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jennschen@chromium.org
, Aug 26 201650.5 KB
50.5 KB View Download