New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641296 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Missing style invalidation for :-webkit-any with multiple type selectors

Reported by r...@opera.com, Aug 26 2016

Issue description

Extracted InvalidationSetFeatures can only contain a single type selector. However, a compound can contain multiple type selectors when used with :-webkit-any():

  .green :-webkit-any(span, div) { color: green }

We need to support multiple type selectors for this. Likewise for #id.

 

Comment 1 by r...@opera.com, Aug 26 2016

Components: Blink>CSS
Labels: OS-All
any.html
290 bytes View Download

Comment 2 by r...@opera.com, Aug 26 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38d4778dc4775085d9e7221cee7e8658942d748f

commit 38d4778dc4775085d9e7221cee7e8658942d748f
Author: rune <rune@opera.com>
Date: Sat Aug 27 11:45:27 2016

Allow multiple type and id selectors in invalidation set features.

:-webkit-any allows for more than one type selector in a compound
selector. Likewise, it may also allow for disjunct id selectors. Make
them vectors in InvalidationSetFeatures like we do for classes and
attributes to make style invalidation work for multiple id and type
selectors in :-webkit-any.

R=ericwilligers@chromium.org,sashab@chromium.org
BUG= 641296 

Review-Url: https://codereview.chromium.org/2284633002
Cr-Commit-Position: refs/heads/master@{#414933}

[add] https://crrev.com/38d4778dc4775085d9e7221cee7e8658942d748f/third_party/WebKit/LayoutTests/fast/css/invalidation/webkit-any.html
[modify] https://crrev.com/38d4778dc4775085d9e7221cee7e8658942d748f/third_party/WebKit/Source/core/css/RuleFeature.cpp
[modify] https://crrev.com/38d4778dc4775085d9e7221cee7e8658942d748f/third_party/WebKit/Source/core/css/RuleFeature.h
[modify] https://crrev.com/38d4778dc4775085d9e7221cee7e8658942d748f/third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp

Comment 5 by r...@opera.com, Aug 27 2016

Status: Fixed (was: Started)

Sign in to add a comment