New issue
Advanced search Search tips

Issue 641289 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram Extensions.OffStoreInstallAllowReason is unmapped

Project Member Reported by ricea@chromium.org, Aug 26 2016

Issue description

The histogram 'Extensions.OffStoreInstallAllowReason' is present in Chromium
source code but does not appear in histograms.xml. This means that data is
collected for the histogram but nothing useful is done with it.

The histogram was defined in chrome/browser/extensions/crx_installer.cc at
line 348.

https://cs.chromium.org/chromium/src/chrome/browser/extensions/crx_installer.cc?l=348

It may have moved by the time you read this.

Please remove the histogram 'Extensions.OffStoreInstallAllowReason' from the
source code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 
Owner: rdevlin....@chromium.org

Comment 2 by holte@chromium.org, Aug 22 2017

Components: -Internals>Metrics
Labels: Hotlist-Metrics

Comment 3 by ricea@chromium.org, May 10 2018

Owner: ricea@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3642258fbb5413d3f828f253170095c66849fd4e

commit 3642258fbb5413d3f828f253170095c66849fd4e
Author: Adam Rice <ricea@chromium.org>
Date: Thu May 10 14:53:03 2018

Remove Extensions\.OffStoreInstall* histograms

The histograms Extensions.OffStoreInstallAllowReason and
Extensions.OffStoreInstallDecisionHard have never been included in
histograms.xml and so no-one has ever looked at the data they produce.

Remove them.

BUG= 641289 

Change-Id: I30e03c52d88bb456bd6aef8318d6e136f8218cc5
Reviewed-on: https://chromium-review.googlesource.com/1053667
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557517}
[modify] https://crrev.com/3642258fbb5413d3f828f253170095c66849fd4e/chrome/browser/extensions/crx_installer.cc

Comment 5 by ricea@chromium.org, May 10 2018

Status: Fixed (was: Started)

Sign in to add a comment