findit/chromium/test.py was broken by remote_run |
||
Issue descriptionIn annotated_run, we would be able to specify the recipe to be run through the build property "recipe" at runtime instead of hard-coded in the master/slave config. However, in remote_run, the build property "recipe" is not respected anymore. Example: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_variable/builds/309
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/7f070732c4b67f610e43d25dfd4ecd61788c15a9 commit 7f070732c4b67f610e43d25dfd4ecd61788c15a9 Author: phajdan.jr <phajdan.jr@chromium.org> Date: Fri Aug 26 12:41:10 2016 remote_run: respect recipe build property BUG= 641248 , 593999 Review-Url: https://codereview.chromium.org/2280983002 [modify] https://crrev.com/7f070732c4b67f610e43d25dfd4ecd61788c15a9/scripts/slave/remote_run.py
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/4dcc139c6af6196e5edf61087b4c6ec80c251b78 commit 4dcc139c6af6196e5edf61087b4c6ec80c251b78 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Aug 26 13:14:10 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/7f070732c4b67f610e43d25dfd4ecd61788c15a9 remote_run: respect recipe build property (phajdan.jr@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 641248 , 593999 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2286683002 [modify] https://crrev.com/4dcc139c6af6196e5edf61087b4c6ec80c251b78/infra/config/recipes.cfg
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d40ce5d15131df4b89acbef72ca53be176a7695a commit d40ce5d15131df4b89acbef72ca53be176a7695a Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Aug 26 15:47:40 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/f1a276cfabcd1f1cc950e36e66a2a50a664ce57f Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/7f070732c4b67f610e43d25dfd4ecd61788c15a9 remote_run: respect recipe build property (phajdan.jr@chromium.org) depot_tools: https://crrev.com/5224ece27c41fab3633feefdec9153786624a66d git_bootstrap.py: add a switch to control client bitness (phajdan.jr@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 641248 , 593999 , 635421 ,629679 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2284653002 Cr-Commit-Position: refs/heads/master@{#414722} [modify] https://crrev.com/d40ce5d15131df4b89acbef72ca53be176a7695a/infra/config/recipes.cfg
,
Aug 26 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/9e8e148390d899db28697b37b26672fab66b3053 commit 9e8e148390d899db28697b37b26672fab66b3053 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Aug 26 15:54:09 2016
,
Aug 27 2016
I've verified that this bug is fixed. Example: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_variable/builds/133 Many thanks for the quick fix! |
||
►
Sign in to add a comment |
||
Comment 1 by st...@chromium.org
, Aug 26 2016