New issue
Advanced search Search tips

Issue 641239 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in blink::PointerEventManager::setPointerCapture

Project Member Reported by ClusterFuzz, Aug 26 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4678153853468672

Fuzzer: inferno_twister_custom_bundle
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  blink::PointerEventManager::setPointerCapture
  blink::ElementV8Internal::setPointerCaptureMethodCallback
  v8::internal::FunctionCallbackArguments::Call
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=411073:411126

Minimized Testcase (3.97 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97WJ0GizGyK3N8f0RazaZz9Ouvc21SS8MTFQgEvdBZtyFmjQ2-MhfRXPIcN8_tdxtpStdHLkAu9Z1LOabbRgldipCS7Z-Ce9VVmPEufFSO2xA07xUTetVOxkGQmjjKGmddBUTKrMR3ZUNFAvXvoxS7VaQZxzQ?testcase_id=4678153853468672

Issue manually filed by: inferno

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Labels: Pri-1
Owner: nzolghadr@chromium.org
Status: Assigned (was: Untriaged)
looks like regression from https://chromium.googlesource.com/chromium/src/+/fbbdbf2f9d8b6ad09d8efba64b70d71563a25120
I believe that change is reverted. So that cannot be the reason I guess.
I had seen this crash before. The problem is that this crash is irreproducible locally even though we used those settings given in the link.
Beside the stack trace is impossible as the setPointerCapture function can only be called via EventHandler and not from V8 internal.

Are you sure that is not caused by one of V8 roll outs?
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 26 2016

Labels: M-54
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 26 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: mmoroz@chromium.org mustaq@chromium.org
This bug is coming back again and again! Do you know who we can ask about V8 and the fact that it jumped to blink::PointerEventManager::setPointerCapture in the stack trace without going through EventHandler class?
Components: Blink>JavaScript

Comment 7 by mmoroz@chromium.org, Aug 27 2016

Cc: tkent@chromium.org yutak@chromium.org
nzolghadr@, let's add more Blink folks here. Hopefully somebody may help to understand that.

Comment 8 by tkent@chromium.org, Aug 28 2016

Components: -Blink>JavaScript Blink>Input
It seems Blink binding layer correctly generates code to call Element::setPointerCapture().  The stack might omit some functions due to compiler optimization.

https://cs.chromium.org/chromium/src/out/Debug/gen/blink/bindings/core/v8/V8Element.cpp?sq=package:chromium&dr=CSs&rcl=1472383144&l=1043

Comment 9 by yutak@chromium.org, Aug 29 2016

Cc: -yutak@chromium.org
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 1 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Friendly ping that M54 beta is coming up this Thursday 9/8 and this is currently a blocker.  Please find an owner and get this fixed as soon as feasible.
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Moving to ReleaseBlock-Stable to keep track of this for M54
Cc: dtapu...@chromium.org
@dtapuska, this bug seems to be going back again and again. So I guess it is consistently being reproduced. But none of us were able to reproduce this locally. How do you think we should proceed? 
Project Member

Comment 14 by ClusterFuzz, Sep 14 2016

ClusterFuzz has detected this issue as fixed in range 418377:418438.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4678153853468672

Fuzzer: inferno_twister_custom_bundle
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  blink::PointerEventManager::setPointerCapture
  blink::ElementV8Internal::setPointerCaptureMethodCallback
  v8::internal::FunctionCallbackArguments::Call
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=411073:411126
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=418377:418438

Minimized Testcase (3.97 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97WJ0GizGyK3N8f0RazaZz9Ouvc21SS8MTFQgEvdBZtyFmjQ2-MhfRXPIcN8_tdxtpStdHLkAu9Z1LOabbRgldipCS7Z-Ce9VVmPEufFSO2xA07xUTetVOxkGQmjjKGmddBUTKrMR3ZUNFAvXvoxS7VaQZxzQ?testcase_id=4678153853468672

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 15 by ClusterFuzz, Sep 14 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 16 by sheriffbot@chromium.org, Sep 14 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 17 by sheriffbot@chromium.org, Sep 16 2016

Labels: Merge-Request-54

Comment 18 by dimu@chromium.org, Sep 17 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 19 by sheriffbot@chromium.org, Sep 20 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by sheriffbot@chromium.org, Sep 23 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Hotlist-Input-Dev
632105 looks to be the same issue and was marked as WontFix.
Labels: -ReleaseBlock-Stable
Project Member

Comment 24 by sheriffbot@chromium.org, Dec 21 2016

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-54

Sign in to add a comment