New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 641212 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Aug 2016
Cc:
█ dim...@chromium.org
fgor...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Duplicate code for openItem with wait in OfflinePageDownloadBridge

Project Member Reported by dim...@chromium.org, Aug 26 2016 
https://codereview.chromium.org/2274573008/
and 
https://codereview.chromium.org/2272883004

both introduced identical blocks of code that get the bridge, wait for it to be loaded, then call openItem. Should be refactored into one method, Likely the static on the bridge should remain.

Comment 1 by fgor...@chromium.org, Aug 26 2016 

The former is not landed yet, and once rebased, will remove the block of code from DownloadNotificationService, moving it to the OfflinePageDownloadBridge.
I don't think we'll need to do work.

Comment 2 by dim...@chromium.org, Aug 29 2016

Status: Fixed (was: Available)
fixed by merge.
►

Sign in to add a comment