WebContents displayed_content_with_cert_errors_ is not cleared on navigation |
|||||||
Issue descriptionIn the new plumbing that I introduced in issue 634171 to handle subresources with cert errors, I neglected to clear the |displayed_content_with_cert_errors_| flag on navigation. This flag should be cleared alongside |displayed_insecure_content_| here: https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.cc?q=web_contents_impl.cc&sq=package:chromium&l=3391
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73583c0beffde96c6797a59fd7f3576ab5f39230 commit 73583c0beffde96c6797a59fd7f3576ab5f39230 Author: estark <estark@chromium.org> Date: Tue Aug 30 17:52:25 2016 Clear |displayed_content_with_cert_errors_| on navigation I added this flag with the new plumbing for subresources with cert errors in https://crbug.com/634171 , but neglected to clear it on navigation. BUG= 641180 Review-Url: https://codereview.chromium.org/2280753003 Cr-Commit-Position: refs/heads/master@{#415345} [modify] https://crrev.com/73583c0beffde96c6797a59fd7f3576ab5f39230/chrome/browser/ssl/ssl_browser_tests.cc [modify] https://crrev.com/73583c0beffde96c6797a59fd7f3576ab5f39230/chrome/test/data/ssl/page_with_subresource.html [modify] https://crrev.com/73583c0beffde96c6797a59fd7f3576ab5f39230/content/browser/web_contents/web_contents_impl.cc
,
Aug 30 2016
,
Aug 30 2016
,
Aug 31 2016
Requesting a merge to M-54 for the commit in comment 2.
,
Aug 31 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbeb7ba8675adaf40b752b4aebabfe3558b2b48e commit bbeb7ba8675adaf40b752b4aebabfe3558b2b48e Author: Emily Stark <estark@google.com> Date: Wed Aug 31 22:05:48 2016 Clear |displayed_content_with_cert_errors_| on navigation I added this flag with the new plumbing for subresources with cert errors in https://crbug.com/634171 , but neglected to clear it on navigation. BUG= 641180 Review-Url: https://codereview.chromium.org/2280753003 Cr-Commit-Position: refs/heads/master@{#415345} (cherry picked from commit 73583c0beffde96c6797a59fd7f3576ab5f39230) Review URL: https://codereview.chromium.org/2302533003 . Cr-Commit-Position: refs/branch-heads/2840@{#85} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/bbeb7ba8675adaf40b752b4aebabfe3558b2b48e/chrome/browser/ssl/ssl_browser_tests.cc [modify] https://crrev.com/bbeb7ba8675adaf40b752b4aebabfe3558b2b48e/chrome/test/data/ssl/page_with_subresource.html [modify] https://crrev.com/bbeb7ba8675adaf40b752b4aebabfe3558b2b48e/content/browser/web_contents/web_contents_impl.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbeb7ba8675adaf40b752b4aebabfe3558b2b48e commit bbeb7ba8675adaf40b752b4aebabfe3558b2b48e Author: Emily Stark <estark@google.com> Date: Wed Aug 31 22:05:48 2016 Clear |displayed_content_with_cert_errors_| on navigation I added this flag with the new plumbing for subresources with cert errors in https://crbug.com/634171 , but neglected to clear it on navigation. BUG= 641180 Review-Url: https://codereview.chromium.org/2280753003 Cr-Commit-Position: refs/heads/master@{#415345} (cherry picked from commit 73583c0beffde96c6797a59fd7f3576ab5f39230) Review URL: https://codereview.chromium.org/2302533003 . Cr-Commit-Position: refs/branch-heads/2840@{#85} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/bbeb7ba8675adaf40b752b4aebabfe3558b2b48e/chrome/browser/ssl/ssl_browser_tests.cc [modify] https://crrev.com/bbeb7ba8675adaf40b752b4aebabfe3558b2b48e/chrome/test/data/ssl/page_with_subresource.html [modify] https://crrev.com/bbeb7ba8675adaf40b752b4aebabfe3558b2b48e/content/browser/web_contents/web_contents_impl.cc
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by est...@chromium.org
, Aug 26 2016