Clicking breaks alt-tab UI |
|||||||||
Issue descriptionM54 | Samus | 8739.0.0 Open some windows: Chrome, Files app, Get Help Alt tab and hold alt Right click on Chrome Alt-Tab UI stays on screen when you let go of alt You can continue to use ChromeOS without keyboard input :)
,
Aug 26 2016
If you click "Alt" or minimizing your windows then your can escape it
,
Aug 26 2016
I dont think very many people are going to click while in the UI
,
Aug 26 2016
,
Aug 29 2016
+sgabriel should mouse click be ignored or should it cancel Alt+Tab?
,
Aug 29 2016
Ignoring click is probably the way to go.
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7e292ea58a76fe27c6c247bc640054bcf4cb6aa commit c7e292ea58a76fe27c6c247bc640054bcf4cb6aa Author: estade <estade@chromium.org> Date: Tue Aug 30 04:30:03 2016 Redirect all mouse input to Alt+Tab window when it's visible, effectively disabling the mouse. Capture is reset when the widget is destroyed. BUG= 641171 Review-Url: https://codereview.chromium.org/2284763002 Cr-Commit-Position: refs/heads/master@{#415096} [modify] https://crrev.com/c7e292ea58a76fe27c6c247bc640054bcf4cb6aa/ash/common/wm/window_cycle_list.cc [modify] https://crrev.com/c7e292ea58a76fe27c6c247bc640054bcf4cb6aa/ash/wm/window_cycle_controller_unittest.cc
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95797140da851b1078706ae6146cb8062d7498eb commit 95797140da851b1078706ae6146cb8062d7498eb Author: perkj <perkj@chromium.org> Date: Tue Aug 30 10:48:22 2016 Revert of Redirect all mouse input to Alt+Tab window when it's visible, (patchset #3 id:40001 of https://codereview.chromium.org/2284763002/ ) Reason for revert: WindowCycleControllerTest.MouseCaptureLost fails on Chrome os and Asan. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(dbg)(1) Original issue's description: > Redirect all mouse input to Alt+Tab window when it's visible, > effectively disabling the mouse. Capture is reset when the widget is > destroyed. > > BUG= 641171 > > Committed: https://crrev.com/c7e292ea58a76fe27c6c247bc640054bcf4cb6aa > Cr-Commit-Position: refs/heads/master@{#415096} TBR=sky@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 641171 Review-Url: https://codereview.chromium.org/2294723002 Cr-Commit-Position: refs/heads/master@{#415267} [modify] https://crrev.com/95797140da851b1078706ae6146cb8062d7498eb/ash/common/wm/window_cycle_list.cc [modify] https://crrev.com/95797140da851b1078706ae6146cb8062d7498eb/ash/wm/window_cycle_controller_unittest.cc
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a1a9aaec662cf0c8bcb24444c180e3fe1456085 commit 5a1a9aaec662cf0c8bcb24444c180e3fe1456085 Author: estade <estade@chromium.org> Date: Wed Aug 31 21:30:03 2016 Retry c7e292ea58a76fe2 - Redirect all mouse input to Alt+Tab window Redirect all mouse input to Alt+Tab window when it's visible, effectively disabling the mouse. Capture is reset when the widget is destroyed. original review: https://codereview.chromium.org/2284763002/ BUG= 641171 Review-Url: https://codereview.chromium.org/2296763002 Cr-Commit-Position: refs/heads/master@{#415761} [modify] https://crrev.com/5a1a9aaec662cf0c8bcb24444c180e3fe1456085/ash/common/wm/window_cycle_list.cc [modify] https://crrev.com/5a1a9aaec662cf0c8bcb24444c180e3fe1456085/ash/common/wm/window_cycle_list.h [modify] https://crrev.com/5a1a9aaec662cf0c8bcb24444c180e3fe1456085/ash/wm/window_cycle_controller_unittest.cc
,
Sep 1 2016
,
Sep 1 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 1 2016
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac1602cb1fd03af6384e56871f29ac90fe6022cb commit ac1602cb1fd03af6384e56871f29ac90fe6022cb Author: Evan Stade <estade@chromium.org> Date: Thu Sep 01 21:23:53 2016 Retry c7e292ea58a76fe2 - Redirect all mouse input to Alt+Tab window Redirect all mouse input to Alt+Tab window when it's visible, effectively disabling the mouse. Capture is reset when the widget is destroyed. original review: https://codereview.chromium.org/2284763002/ BUG= 641171 Review-Url: https://codereview.chromium.org/2296763002 Cr-Commit-Position: refs/heads/master@{#415761} (cherry picked from commit 5a1a9aaec662cf0c8bcb24444c180e3fe1456085) Review URL: https://codereview.chromium.org/2303043002 . Cr-Commit-Position: refs/branch-heads/2840@{#108} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/ac1602cb1fd03af6384e56871f29ac90fe6022cb/ash/common/wm/window_cycle_list.cc [modify] https://crrev.com/ac1602cb1fd03af6384e56871f29ac90fe6022cb/ash/common/wm/window_cycle_list.h [modify] https://crrev.com/ac1602cb1fd03af6384e56871f29ac90fe6022cb/ash/wm/window_cycle_controller_unittest.cc
,
Oct 18 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac1602cb1fd03af6384e56871f29ac90fe6022cb commit ac1602cb1fd03af6384e56871f29ac90fe6022cb Author: Evan Stade <estade@chromium.org> Date: Thu Sep 01 21:23:53 2016 Retry c7e292ea58a76fe2 - Redirect all mouse input to Alt+Tab window Redirect all mouse input to Alt+Tab window when it's visible, effectively disabling the mouse. Capture is reset when the widget is destroyed. original review: https://codereview.chromium.org/2284763002/ BUG= 641171 Review-Url: https://codereview.chromium.org/2296763002 Cr-Commit-Position: refs/heads/master@{#415761} (cherry picked from commit 5a1a9aaec662cf0c8bcb24444c180e3fe1456085) Review URL: https://codereview.chromium.org/2303043002 . Cr-Commit-Position: refs/branch-heads/2840@{#108} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/ac1602cb1fd03af6384e56871f29ac90fe6022cb/ash/common/wm/window_cycle_list.cc [modify] https://crrev.com/ac1602cb1fd03af6384e56871f29ac90fe6022cb/ash/common/wm/window_cycle_list.h [modify] https://crrev.com/ac1602cb1fd03af6384e56871f29ac90fe6022cb/ash/wm/window_cycle_controller_unittest.cc |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dhadd...@chromium.org
, Aug 26 2016