New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641142 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 616447



Sign in to add a comment

WinAudioInputTest.WASAPIAudioInputStreamTestPacketSizes failing on Windows

Project Member Reported by kbr@chromium.org, Aug 25 2016

Issue description

WinAudioInputTest.WASAPIAudioInputStreamTestPacketSizes from the audio_unittests target is failing on Windows. First failing builds on a couple of builders:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NVIDIA%29/builds/27139
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28ATI%29/builds/23291

We think https://chromium.googlesource.com/chromium/src/+/6ef45cf47455fb44e8fa0ab5d1ba545c91429941 is likely to be the root cause.

I'm blocking  Issue 616447  on this one and marking it P1. fdoray@, could you please help investigate this? We are going to disable the test in the meantime.

 

Comment 1 by kbr@chromium.org, Aug 25 2016

Cc: phoglund@chromium.org olka@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/134f2a8d2eb76219bb8d650970859116dfb1606e

commit 134f2a8d2eb76219bb8d650970859116dfb1606e
Author: kbr <kbr@chromium.org>
Date: Fri Aug 26 00:06:17 2016

Temporarily disable WinAudioInputTest.WASAPIAudioInputStreamTestPacketSizes .

It started failing on the chromium.gpu.fyi bots recently. Disabling it
since the CL that we think regressed it made it through the CQ
successfully, and we don't necessarily want to revert it.

BUG= 641142 

Review-Url: https://codereview.chromium.org/2286473002
Cr-Commit-Position: refs/heads/master@{#414587}

[modify] https://crrev.com/134f2a8d2eb76219bb8d650970859116dfb1606e/media/audio/win/audio_low_latency_input_win_unittest.cc

Comment 3 by fdoray@chromium.org, Aug 26 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7accaec8bb0f2bc5172e816370895b3e5cb1d874

commit 7accaec8bb0f2bc5172e816370895b3e5cb1d874
Author: fdoray <fdoray@chromium.org>
Date: Fri Aug 26 19:42:32 2016

Fix and enable WinAudioInputTest.WASAPIAudioInputStreamTestPacketSizes.

Contrary to what had been assumed, CheckCountAndPostQuitTask doesn't
run on the main thread. Because of that, it cannot quit the RunLoop
running on the main thread by calling its QuitWhenIdle function; it
needs to post a QuitWhenIdleClosure to it.

BUG= 641142 

Review-Url: https://codereview.chromium.org/2284693003
Cr-Commit-Position: refs/heads/master@{#414783}

[modify] https://crrev.com/7accaec8bb0f2bc5172e816370895b3e5cb1d874/media/audio/win/audio_low_latency_input_win_unittest.cc

Comment 5 by fdoray@chromium.org, Aug 29 2016

Status: Fixed (was: Started)

Comment 6 by kbr@chromium.org, Aug 29 2016

Thanks for the prompt fix.

Sign in to add a comment