New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 641140 link

Starred by 1 user
Status: Fixed
Owner:
hayato@chromium.org
Closed: Sep 2016
Cc:
█ ranjitkan@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

'slotchange' event does not bubble

Project Member Reported by bickne...@google.com, Aug 25 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Example URL:
http://jsbin.com/mubotiwiha/1/edit?html,console,output

Steps to reproduce the problem:
1. Open the linked page.
2. Click the text "test-element".
3. Both "non-bubbling slotchange" and "bubbling slotchange" should be logged to the console, but only "non-bubbling slotchange" is logged.

What is the expected behavior?

What went wrong?
'slotchange' events should bubble, but they don't.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? No 

Does this work in other browsers? N/A 

Chrome version: 52.0.2743.116  Channel: stable
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 22.0 r0

Looks like this line should use `Event::createBubble` instead of `Event::create`:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp?q=slotchange&sq=package:chromium&dr=CSs&l=157

Comment 1 by bickne...@google.com, Aug 25 2016 

Sorry, I filed this with stable and forgot to change the version.
This is the correct affected version, along with the flag `--enable-blink-features=CustomElementsV1`:

54.0.2839.0 (Official Build) canary (64-bit)
Revision	911ba12253b14bfe874a321c57031f5ac534ce31-refs/heads/master@{#414243}

Comment 2 by ranjitkan@chromium.org, Aug 26 2016

Cc: ranjitkan@chromium.org
Labels: M-54
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue is observed from M53 builds, On Stable 52.0.2743.116 Nothing is displayed in console on clicking the text when enabled the flag. on Beta 53.0.2785.80 only "non-bubbling slotchange" is displayed. Same result is displayed on Canary version 54.0.2840.0.

On Windows and Ubuntu 14.04. The JS-Bin Console is displayed with errors.

Untriaging it so that it gets addressed.

Thanks.!
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 26 2016

Labels: Hotlist-Google

Comment 4 by chrishtr@chromium.org, Aug 26 2016

Components: -Blink Blink>DOM

Comment 5 by tkent@chromium.org, Sep 2 2016

Components: -Blink>DOM Blink>WebComponents

Comment 6 by hayato@chromium.org, Sep 2 2016

Owner: hayato@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db300b7b07375236467cfcc9aad82b8f8affa36b

commit db300b7b07375236467cfcc9aad82b8f8affa36b
Author: hayato <hayato@chromium.org>
Date: Fri Sep 02 05:47:21 2016

Make slotchange events bubble

The spec is: https://dom.spec.whatwg.org/#notify-mutation-observers ; open this link, and find-in-page by "slotchange".
This CL is a bug fix. The current behavior is unintentional.

BUG= 641140 

Review-Url: https://codereview.chromium.org/2306873002
Cr-Commit-Position: refs/heads/master@{#416197}

[modify] https://crrev.com/db300b7b07375236467cfcc9aad82b8f8affa36b/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html
[modify] https://crrev.com/db300b7b07375236467cfcc9aad82b8f8affa36b/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

Comment 8 by hayato@chromium.org, Sep 2 2016

Labels: -OS-Mac OS-All
Status: Fixed (was: Assigned)
►

Sign in to add a comment