Confirm user removal button UX |
||||
Issue descriptionM54 Samus | 8739.0.0 Steps to repro: Try to remove a non-owner from the device. See the confirmation text. I'm definitely nitpicking here but the "Remove This User" button looks a bit strange as it does not have a hover state. With a longer email address the text also seems pretty broken up. Functionality wise this is fine though Screenshot attached
,
Aug 25 2016
Style is mostly borrowed from removing supervised user. @omrilio, do we need hover state for the second seen "Remove this user"? As for the email address, currently it is a span element and it makes sure email address is not broken into multi lines. If that is not the behavior wanted, I can change it.
,
Aug 29 2016
,
Aug 29 2016
CrOS "remove this user" button should use red button style just like desktop browser
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b316f87f5c0d4bb686c66867dded237fcc2275e4 commit b316f87f5c0d4bb686c66867dded237fcc2275e4 Author: warx <warx@chromium.org> Date: Wed Aug 31 05:49:19 2016 CrOS "remove this user" button should use red button style just like desktop browser Remove this user button for supervised user is changed to back bold font style not by design. This CL restores the red button style for both removing non-owner user and supervised user. BUG= 641137 TEST=device test. Screenshots are in crbug.com/641137 . Review-Url: https://codereview.chromium.org/2293683002 Cr-Commit-Position: refs/heads/master@{#415570} [modify] https://crrev.com/b316f87f5c0d4bb686c66867dded237fcc2275e4/ui/login/account_picker/user_pod_row.css [add] https://crrev.com/b316f87f5c0d4bb686c66867dded237fcc2275e4/ui/login/account_picker/user_pod_template.css [modify] https://crrev.com/b316f87f5c0d4bb686c66867dded237fcc2275e4/ui/login/account_picker/user_pod_template.html
,
Aug 31 2016
"Remove this user" button is changed to red button style. The email address seems not a concern through email contact. Mark it as fixed.
,
Oct 25 2016
Verified on ChromeOS 8872.22.0, 55.0.2883.25 |
||||
►
Sign in to add a comment |
||||
Comment 1 by abodenha@chromium.org
, Aug 25 2016Status: Assigned (was: Untriaged)