New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641133 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 649825

Blocking:
issue 639755
issue 641015



Sign in to add a comment

Bisect not descending into rolls

Project Member Reported by sullivan@chromium.org, Aug 25 2016

Issue description

Blocking: 640536
Blocking: 640531
Blocking: 640530
Blocking: 639755
Blocking: 641015
Blocking: -640531
Blocking: -640530
Blocking: -640536
Actually, this seems like just the catapult rolls, the v8 rolls are failing due to bug 640915
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/59a238ef7b257e8a6bbe1583774cc2d84b4ced72

commit 59a238ef7b257e8a6bbe1583774cc2d84b4ced72
Author: robertocn <robertocn@google.com>
Date: Mon Aug 29 18:50:32 2016

Do not exclude the last revision in the range returned by gitiles.

Originally we excluded the last revision in the range, because that
operation included the revision given as the end. When expanding the
revision range the 'bad' revision is the end revision, and we don't want
to instantiate it again, since we already do that when starting the
bisect jobs. When reusing this code for expanding rolls, we ended up
also discarding the end revision, which makes for one-revision rolls to
break and also excludes the last revision in the roll.

BUG= 641133 
R=prasadv,dtu,sullivan

Review-Url: https://codereview.chromium.org/2282563004

[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/bisector.py
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/example.expected/android_bisector.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_test.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/example.py
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/resources/fetch_intervening_revisions.py
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipe_modules/auto_bisect/resources/fetch_intervening_revisions_test.py
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipes/bisect.expected/basic.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipes/bisect.expected/basic_return_code_test.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipes/bisect.expected/broken_bad_revision_test.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipes/bisect.expected/broken_good_revision_test.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipes/bisect.py
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_basic_device.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_disconnected_device.json
[modify] https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_failed_device.json

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 29 2016

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/fe1ef031ce0b5c9ef6579b51f37b04b7047a4574

commit fe1ef031ce0b5c9ef6579b51f37b04b7047a4574
Author: recipe-roller <recipe-roller@chromium.org>
Date: Mon Aug 29 19:14:15 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/59a238ef7b257e8a6bbe1583774cc2d84b4ced72 Do not exclude the last revision in the range returned by gitiles. (robertocn@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 641133 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2290793002

[modify] https://crrev.com/fe1ef031ce0b5c9ef6579b51f37b04b7047a4574/infra/config/recipes.cfg

Just got another strange bisect that didn't seem to descend into the catapult roll: https://bugs.chromium.org/p/chromium/issues/detail?id=641015#c10
sullivan@ the bisect you mention in #13 did descend into catapult, and there is a single revision inside the roll. The strange part is that it found a difference between chromium@413390,catapult@947506bacf (pre-roll plus only revision in the roll) and chromium@413391 (the roll). One possibility is that the build for 413390 plus catapult@94750 does not really have the catapult revision patched in. I will see if I can find evidence to reject this possibility.                    
Cc: dtu@chromium.org
The build seems to be correct. (https://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_bisect_builder/builds/4045) I don't really know what the difference may be between chromium@413390,catapult@947506bacf (pre-roll plus only revision in the roll) and chromium@413391 (the roll)

dtu@, do you have any idea what the issue may be?
Blocking: 645961
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/6becba49e8283ade6bccccd7316006e51ef3840e

commit 6becba49e8283ade6bccccd7316006e51ef3840e
Author: robertocn <robertocn@chromium.org>
Date: Fri Sep 23 21:57:21 2016

Add catapult to the list of supported repos for fetch_revision_info.py

The upcoming refactor will do away with this resources script in favor
of the gitiles recipe module, but for now we need to support culprits in
catapult.

R=dtu@chromium.org,prasadv@chromium.org,sullivan@chromium.org
BUG= 641133 

Review-Url: https://codereview.chromium.org/2365973004

[modify] https://crrev.com/6becba49e8283ade6bccccd7316006e51ef3840e/scripts/slave/recipe_modules/auto_bisect/resources/depot_map.py

Blockedon: 649825
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/2eec8d84d85a76ea895b9fbca59d88e43209655d

commit 2eec8d84d85a76ea895b9fbca59d88e43209655d
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 23 22:16:01 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/6becba49e8283ade6bccccd7316006e51ef3840e Add catapult to the list of supported repos for fetch_revision_info.py (robertocn@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 641133 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2370563002

[modify] https://crrev.com/2eec8d84d85a76ea895b9fbca59d88e43209655d/infra/config/recipes.cfg

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c87164b88c3451d7158b1ad23a95510958cdebeb

commit c87164b88c3451d7158b1ad23a95510958cdebeb
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 23 23:05:37 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/c46863ea216f3686ff15ccbafa23964e3e564abf Fix LogDog bootstrap params, add test. (dnj@chromium.org)
  https://crrev.com/6becba49e8283ade6bccccd7316006e51ef3840e Add catapult to the list of supported repos for fetch_revision_info.py (robertocn@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=None,641133

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2363903003
Cr-Commit-Position: refs/heads/master@{#420769}

[modify] https://crrev.com/c87164b88c3451d7158b1ad23a95510958cdebeb/infra/config/recipes.cfg

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 26 2016

Status: Fixed (was: Untriaged)
Cc: sullivan@chromium.org zxiong@google.com robert...@chromium.org
 Issue 625329  has been merged into this issue.
Blocking: -645961
Components: Speed>Bisection

Sign in to add a comment