New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641130 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

arc: Default and OEM apps support

Project Member Reported by khmel@chromium.org, Aug 25 2016

Issue description

Inner bug: b/30953084
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a710e40ddcc54f50f8279cd41ae19f5d170bd00

commit 6a710e40ddcc54f50f8279cd41ae19f5d170bd00
Author: khmel <khmel@chromium.org>
Date: Tue Aug 30 23:53:12 2016

arc: Add support of default and OEM apps.

This implements support for default and OEM Arc apps. These apps are
visible before OptIn. Activating this when Arc is not opted in starts
OptIn flow and schedules deferred launch for this app. User may remove
these apps and default apps stay non vosible until explicitly installed
again. Oem apps exists in app list OEM folder.
Such apps required to be installed in vendor/system Android image or
implement auto-install feature.
https://drive.google.com/a/google.com/file/d/0B373dspH0jyNWVpMVmhVdWJBeTg/view

Preview available here:
https://drive.google.com/file/d/0B63tZNwdjs-qby15dXZyUHBSTEU/view

BUG=b/30953084
BUG= 641130 
TEST=Manually on device
TEST=Extended unit_tests

Review-Url: https://codereview.chromium.org/2281743002
Cr-Commit-Position: refs/heads/master@{#415498}

[modify] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/app_list/app_list_syncable_service.cc
[modify] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/app_list/arc/arc_app_test.cc
[modify] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/app_list/arc/arc_app_test.h
[modify] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[add] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/app_list/arc/arc_default_app_list.cc
[add] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/app_list/arc/arc_default_app_list.h
[modify] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
[modify] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h
[modify] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
[modify] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/chrome_browser_ui.gypi
[add] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/test/data/arc_default_apps/test_app1.json
[add] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/test/data/arc_default_apps/test_app1/icon_100p.png
[add] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/test/data/arc_default_apps/test_app1/icon_200p.png
[add] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/test/data/arc_default_apps/test_app2.json
[add] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/test/data/arc_default_apps/test_app2/icon_100p.png
[add] https://crrev.com/6a710e40ddcc54f50f8279cd41ae19f5d170bd00/chrome/test/data/arc_default_apps/test_app2/icon_200p.png

Comment 2 by khmel@chromium.org, Sep 7 2016

Labels: Merge-Request-53 Merge-Request-54
 crbug.com/643686  is targeted to M53 and requires this CL as base.

Comment 3 by dimu@chromium.org, Sep 7 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M53), manual review required.

Comment 4 by dimu@chromium.org, Sep 7 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df

commit 59375e6696cfa567bfebcd291a1c8e4bcb4aa8df
Author: khmel <khmel@chromium.org>
Date: Wed Sep 07 22:03:21 2016

[Merge-M54] arc: Add support of default and OEM apps.

This implements support for default and OEM Arc apps. These apps are
visible before OptIn. Activating this when Arc is not opted in starts
OptIn flow and schedules deferred launch for this app. User may remove
these apps and default apps stay non vosible until explicitly installed
again. Oem apps exists in app list OEM folder.
Such apps required to be installed in vendor/system Android image or
implement auto-install feature.
https://drive.google.com/a/google.com/file/d/0B373dspH0jyNWVpMVmhVdWJBeTg/view

Preview available here:
https://drive.google.com/file/d/0B63tZNwdjs-qby15dXZyUHBSTEU/view

BUG=b/30953084
BUG= 641130 
TEST=Manually on device
TEST=Extended unit_tests

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2281743002
Cr-Commit-Position: refs/heads/master@{#415498}
(cherry picked from commit 6a710e40ddcc54f50f8279cd41ae19f5d170bd00)

Review-Url: https://codereview.chromium.org/2322683003
Cr-Commit-Position: refs/branch-heads/2840@{#218}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/app_list_syncable_service.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_app_test.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_app_test.h
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_default_app_list.cc
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_default_app_list.h
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/chrome_browser_ui.gypi
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/test/data/arc_default_apps/test_app1.json
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/test/data/arc_default_apps/test_app1/icon_100p.png
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/test/data/arc_default_apps/test_app1/icon_200p.png
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/test/data/arc_default_apps/test_app2.json
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/test/data/arc_default_apps/test_app2/icon_100p.png
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/test/data/arc_default_apps/test_app2/icon_200p.png

Cc: bhthompson@chromium.org
Labels: -Hotlist-Merge-review -Merge-Review-53 Merge-Approved-53
This appears to be ARC specific, if we are confident this is the case please feel free to merge. 
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 9 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b836869e08e765fc1cad8dfa9ef277f18202edf8

commit b836869e08e765fc1cad8dfa9ef277f18202edf8
Author: khmel <khmel@chromium.org>
Date: Fri Sep 09 16:50:47 2016

[Merge-M53] arg: Add support of default and OEM apps.

This implements support for default and OEM Arc apps. These apps are
visible before OptIn. Activating this when Arc is not opted in starts
OptIn flow and schedules deferred launch for this app. User may remove
these apps and default apps stay non vosible until explicitly installed
again. Oem apps exists in app list OEM folder.
Such apps required to be installed in vendor/system Android image or
implement auto-install feature.
https://drive.google.com/a/google.com/file/d/0B373dspH0jyNWVpMVmhVdWJBeTg/view

Preview available here:
https://drive.google.com/file/d/0B63tZNwdjs-qby15dXZyUHBSTEU/view

BUG=b/30953084
BUG= 641130 
TEST=Manually on device
TEST=Extended unit_tests

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2281743002
Cr-Commit-Position: refs/heads/master@{#415498}

(cherry picked from commit 6a710e40ddcc54f50f8279cd41ae19f5d170bd00)

Review-Url: https://codereview.chromium.org/2322353002
Cr-Commit-Position: refs/branch-heads/2785@{#862}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/app_list/app_list_syncable_service.cc
[modify] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/app_list/arc/arc_app_test.cc
[modify] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/app_list/arc/arc_app_test.h
[modify] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[add] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/app_list/arc/arc_default_app_list.cc
[add] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/app_list/arc/arc_default_app_list.h
[modify] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
[modify] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h
[modify] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
[modify] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/chrome_browser_ui.gypi
[add] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/test/data/arc_default_apps/test_app1.json
[add] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/test/data/arc_default_apps/test_app1/icon_100p.png
[add] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/test/data/arc_default_apps/test_app1/icon_200p.png
[add] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/test/data/arc_default_apps/test_app2.json
[add] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/test/data/arc_default_apps/test_app2/icon_100p.png
[add] https://crrev.com/b836869e08e765fc1cad8dfa9ef277f18202edf8/chrome/test/data/arc_default_apps/test_app2/icon_200p.png

Comment 9 by khmel@chromium.org, Sep 9 2016

Status: Fixed (was: Started)
Labels: VerifyIn-55
Status: Verified (was: Fixed)
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df

commit 59375e6696cfa567bfebcd291a1c8e4bcb4aa8df
Author: khmel <khmel@chromium.org>
Date: Wed Sep 07 22:03:21 2016

[Merge-M54] arc: Add support of default and OEM apps.

This implements support for default and OEM Arc apps. These apps are
visible before OptIn. Activating this when Arc is not opted in starts
OptIn flow and schedules deferred launch for this app. User may remove
these apps and default apps stay non vosible until explicitly installed
again. Oem apps exists in app list OEM folder.
Such apps required to be installed in vendor/system Android image or
implement auto-install feature.
https://drive.google.com/a/google.com/file/d/0B373dspH0jyNWVpMVmhVdWJBeTg/view

Preview available here:
https://drive.google.com/file/d/0B63tZNwdjs-qby15dXZyUHBSTEU/view

BUG=b/30953084
BUG= 641130 
TEST=Manually on device
TEST=Extended unit_tests

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2281743002
Cr-Commit-Position: refs/heads/master@{#415498}
(cherry picked from commit 6a710e40ddcc54f50f8279cd41ae19f5d170bd00)

Review-Url: https://codereview.chromium.org/2322683003
Cr-Commit-Position: refs/branch-heads/2840@{#218}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/app_list_syncable_service.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_app_test.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_app_test.h
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_default_app_list.cc
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/app_list/arc/arc_default_app_list.h
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/chrome_browser_ui.gypi
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/test/data/arc_default_apps/test_app1.json
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/test/data/arc_default_apps/test_app1/icon_100p.png
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/test/data/arc_default_apps/test_app1/icon_200p.png
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/test/data/arc_default_apps/test_app2.json
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/test/data/arc_default_apps/test_app2/icon_100p.png
[add] https://crrev.com/59375e6696cfa567bfebcd291a1c8e4bcb4aa8df/chrome/test/data/arc_default_apps/test_app2/icon_200p.png

Sign in to add a comment