New issue
Advanced search Search tips

Issue 641126 link

Starred by 1 user
Status: Fixed
Owner:
sorin@chromium.org
Closed: Sep 2016
Cc:
waff...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Extension uninstall events look like they originate from the component updater

Project Member Reported by waff...@chromium.org, Aug 25 2016 
extensions/browser/updater/update_service.cc::SendUninstallPing winds up serializing version="chrome-54.0.1234.56" (for example) in the Omaha request. It should instead serialize version="chromecrx-54.0.1234.56" so that the server can identify the item in question as an extension.

Comment 1 Deleted

Comment 2 by sorin@chromium.org, Sep 7 2016 

Comment #1 was deleted as spam, please resubmit if for some reason the comment was valid.

Comment 3 by sorin@chromium.org, Sep 14 2016

Cc: -sorin@chromium.org waff...@chromium.org
Owner: sorin@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a4bb4878548bd119d990b5c37b15f9a11ece00f

commit 3a4bb4878548bd119d990b5c37b15f9a11ece00f
Author: sorin <sorin@chromium.org>
Date: Mon Sep 19 19:23:12 2016

Inject the prodid for the extensions and component updaters.

This allows both updaters to use specific and correct prodids when
reporting the "version" in the update check and ping  requests.

BUG= 641126 

Review-Url: https://codereview.chromium.org/2340113002
Cr-Commit-Position: refs/heads/master@{#419529}

[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc
[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/chrome/browser/extensions/updater/chrome_update_client_config.cc
[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/chrome/browser/extensions/updater/chrome_update_client_config.h
[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/components/update_client/configurator.h
[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/components/update_client/ping_manager.cc
[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/components/update_client/test_configurator.cc
[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/components/update_client/test_configurator.h
[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/components/update_client/update_checker.cc
[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/components/update_client/utils.cc
[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/components/update_client/utils.h
[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/components/update_client/utils_unittest.cc
[modify] https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc

Comment 5 by sorin@chromium.org, Sep 23 2016

Status: Fixed (was: Started)
►

Sign in to add a comment