New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641113 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 591845



Sign in to add a comment

Delete media/ gyp files

Project Member Reported by w...@chromium.org, Aug 25 2016

Issue description

After M54 branches we have the go-ahead to delete these.
 

Comment 1 by w...@chromium.org, Aug 25 2016

Cc: wolenetz@chromium.org
Gyp deprecation announcement: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/NZkPr-CXvQ0

Comment 2 by w...@chromium.org, Aug 25 2016

Cc: -wolenetz@chromium.org
cc'd wolenetz@ in case we need to coordinate around FFmpeg roll.
Blocking: 591845
Not fully blocking the ffmpeg roll, but linking that bug here to keep it on my radar when rolling.

Comment 5 by w...@chromium.org, Aug 26 2016

I just realized that 54 hasn't actually branched yet. We'll be fine as long as no one does a deps roll before the 54 branch
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd8f9885e1a55d7388056632f12723481181dcfb

commit cd8f9885e1a55d7388056632f12723481181dcfb
Author: watk <watk@chromium.org>
Date: Sat Aug 27 11:07:58 2016

Delete gyp files from media/

After this CL there are no more references to gyp anywhere in media/.

BUG= 641113 

Review-Url: https://codereview.chromium.org/2279593004
Cr-Commit-Position: refs/heads/master@{#414923}

[modify] https://crrev.com/cd8f9885e1a55d7388056632f12723481181dcfb/media/BUILD.gn
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/base/ipc/media_base_ipc.gyp
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/blink/media_blink.gyp
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/capture/capture.gyp
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/cast/cast.gyp
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/cast/cast_testing.gypi
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/cast/cast_testing_tools.gypi
[modify] https://crrev.com/cd8f9885e1a55d7388056632f12723481181dcfb/media/cast/test/proto/BUILD.gn
[modify] https://crrev.com/cd8f9885e1a55d7388056632f12723481181dcfb/media/cdm/cdm_paths.cc
[modify] https://crrev.com/cd8f9885e1a55d7388056632f12723481181dcfb/media/cdm/ppapi/BUILD.gn
[modify] https://crrev.com/cd8f9885e1a55d7388056632f12723481181dcfb/media/cdm/ppapi/external_clear_key/cdm_video_decoder.h
[modify] https://crrev.com/cd8f9885e1a55d7388056632f12723481181dcfb/media/cdm/ppapi/ppapi_cdm_adapter.gni
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/cdm_paths.gypi
[modify] https://crrev.com/cd8f9885e1a55d7388056632f12723481181dcfb/media/ffmpeg/ffmpeg_common.h
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/gpu/ipc/media_ipc.gyp
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/media.gyp
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/media_cdm.gypi
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/media_cdm_adapter.gyp
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/media_gpu.gypi
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/media_nacl.gyp
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/media_variables.gypi
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/midi/midi.gyp
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/mojo/interfaces/mojo_bindings.gyp
[delete] https://crrev.com/e516887a797e8e8aa71c00cc21a8359b96ede1e7/media/shared_memory_support.gypi

Comment 7 by w...@chromium.org, Aug 29 2016

Status: Fixed (was: Started)
I'll let the ffmpeg change be pulled in with the next deps roll; there's no rush.

Sign in to add a comment