New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 641107 link

Starred by 2 users
Status: WontFix
Owner:
█ ian...@chromium.org
Away
Closed: Aug 2016
Cc:
yus...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Back button is always white in Chrome Custom Tabs

Project Member Reported by est...@chromium.org, Aug 25 2016 
It looks like the Back arrow in CCT is always white, which looks weird on the default color as well as light colors. See attached screenshots.
Screenshot_2016-08-25-13-10-52.png
656 KB View Download
Screenshot_2016-08-25-13-15-20.png
664 KB View Download
Screenshot_2016-08-25-13-11-53.png
665 KB View Download

Comment 1 by yus...@chromium.org, Aug 25 2016

Owner: ian...@chromium.org
Status: Assigned (was: Unconfirmed)
Eww. I very much hope this is a recent regression. Are you seeing this on 54?

Comment 2 by est...@chromium.org, Aug 25 2016 

I'm seeing this on 52.0.2743.98 :( Unless somehow ToT CustomTabsClientExample is causing it, but I don't see how that could be. I'm building CustomTabsClientExample from ToT with the setToolbarColor() call removed. Then connecting to com.android.chrome which is 52.0.2743.98 on my device.

Comment 3 by yus...@chromium.org, Aug 25 2016 

:(

That makes me really sad. Granted most clients setToolbarColor to something, not sure how this ended up regressing.

Comment 4 by yus...@chromium.org, Aug 25 2016

Labels: -M-54 M-53
I know it is pretty late, let's see if we can actually get this for 53.

Comment 5 by jay...@chromium.org, Aug 25 2016 

Could this be because the CustomTabsClientExample sets a custom Bitmap icon (the arrow)? If you remove the custom icon (by removing builder.setCloseButtonIcon(..)), the default "X" close button changes to white/black correctly depending on the toolbar color.

Comment 6 by yus...@chromium.org, Aug 25 2016

Status: WontFix (was: Assigned)
Yeah, you are right. I have been pulling my hair off while trying this on various apps and not getting a white back button. Seems like this is a client issue after all.

Comment 7 by est...@chromium.org, Aug 25 2016 

Wphew! Sorry for the false alarm!

Comment 8 by jay...@chromium.org, Feb 14 2017 

Issue 692160 has been merged into this issue.
►

Sign in to add a comment