Content layering violation in chrome/browser/ui/bluetooth |
||
Issue descriptionThis review: https://codereview.chromium.org/2203103003/ added an include of: content/browser/bluetooth/bluetooth_metrics.h from Chrome and a new DEPS rule to whitelist this include for checkdeps. However, this bypasses the content API and should not be allowed. Headers included outside of content should be in content/public/* Either the metrics header needs to be moved or the metrics thing needs to be done a different way. This is blocking whitelisting //chrome/browser/ui for "gn check" which also would have caught this layering violation.
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d924f0d278c6edee2872427b89a2f44a6fb0781 commit 2d924f0d278c6edee2872427b89a2f44a6fb0781 Author: ortuno <ortuno@chromium.org> Date: Fri Aug 26 18:43:38 2016 bluetooth: Fix layering violation in BluetoothChooserController BluetoothChooserController, which is in chrome/, was including BluetoothMetrics which is in content/. To avoid this we create a new histogram specifically for interactions with the chooser. BUG= 641105 Review-Url: https://codereview.chromium.org/2278003003 Cr-Commit-Position: refs/heads/master@{#414758} [delete] https://crrev.com/2b47da8b7e8cb3eac24be2d809a612a89794f11c/chrome/browser/ui/bluetooth/DEPS [modify] https://crrev.com/2d924f0d278c6edee2872427b89a2f44a6fb0781/chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc [modify] https://crrev.com/2d924f0d278c6edee2872427b89a2f44a6fb0781/tools/metrics/histograms/histograms.xml
,
Aug 26 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by ortuno@chromium.org
, Aug 25 2016Status: Started (was: Assigned)