New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641097 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

ftp: sorting shouldn't include parent directory

Reported by pdk...@gmail.com, Aug 25 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.70 Safari/537.36

Example URL:
ftp://ftp.adobe.com/pub/

Steps to reproduce the problem:
1. ftp://ftp.adobe.com/pub/
2. Click on columns to sort.

What is the expected behavior?
The parent directory stays at the top.

What went wrong?
It jumps around, usually to the bottom.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? No 

Does this work in other browsers? Yes 

Chrome version: 53.0.2785.70  Channel: n/a
OS Version: 
Flash Version:
 
Components: -Blink Internals>Network>FTP
Not Blink. Probably should be UI>Browser, too? Will let Network folks decide.
Cc: rnimmagadda@chromium.org
Labels: M-53 OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to repro this issue on Windows 7, MAC (10.11.6) & Ubuntu Trusty (14.04) for Google Chrome Stable Version - 52.0.2743.116

This is a Non-Regression issue existing from M30 - # 30.0.1549.0
Labels: -Pri-2 -M-53 Pri-3
Apparently FTP listing are actually fancy HTML pages. See r377943. Looking in net/base/dir_header.html, there's some ".." handling code, but it may not be doing the right thing.
Owner: thestig@chromium.org
Status: Started (was: Untriaged)
https://codereview.chromium.org/2792533003

Comment 5 by pdk...@gmail.com, Apr 3 2017

You may also be interested in this FTP bug.

https://bugs.chromium.org/p/chromium/issues/detail?id=633841
Labels: M-60
re: comment 5 - maybe, but I'm not really interested in owning all the FTP bugs.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9719cebca5c0195cbac3e23a8ec9a363c78932f1

commit 9719cebca5c0195cbac3e23a8ec9a363c78932f1
Author: thestig <thestig@chromium.org>
Date: Thu Apr 20 20:20:42 2017

Separate the parent directory link in FTP listings.

Thus it won't get sorted along with the rest of the file listings and
end up on the bottom.

BUG= 641097 

Review-Url: https://codereview.chromium.org/2792533003
Cr-Commit-Position: refs/heads/master@{#466103}

[modify] https://crrev.com/9719cebca5c0195cbac3e23a8ec9a363c78932f1/content/child/ftp_directory_listing_response_delegate.cc
[modify] https://crrev.com/9719cebca5c0195cbac3e23a8ec9a363c78932f1/net/base/dir_header.html

Status: Fixed (was: Started)

Sign in to add a comment