Issue metadata
Sign in to add a comment
|
ftp: date not displayed
Reported by
pdk...@gmail.com,
Aug 25 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.70 Safari/537.36 Example URL: ftp://ftp.adobe.com/ Steps to reproduce the problem: ftp://ftp.adobe.com/ What is the expected behavior? Last Modified column displays dates. What went wrong? It doesn't. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? N/A Does this work in other browsers? Yes Chrome version: 53.0.2785.70 Channel: beta OS Version: Ubuntu 14.04 Flash Version: This affects every FTP site. The culprit is between 399793 (GOOD) and 399796 (NOT). It can only be 399794. https://chromium.googlesource.com/chromium/src/+/558f168054566ecbc611918093398add04dc13a4
,
Aug 25 2016
When I hit ftp://ftp.adobe.com/, I see dates in the Date Modified column. /Acrobat, for example, says “5/20/05, 12:00:00 AM”. Is this not expected? Canary 54.0.2839.0 on Mac, 911ba12253b14bfe874a321c57031f5ac534ce31 (master@{#414243})
,
Aug 25 2016
Then it's Linux-only, or perhaps Ubuntu-only. I assumed it may also
affect Mac in my CL comment because Mac is mentioned in the
description.
Anyway, this is what I get in view-source: of the FTP page.
<script>addRow("Acrobat","Acrobat",1,0,"0 B",0,"");</script>
<script>addRow("Broker","Broker",1,0,"0 B",0,"");</script>
<script>addRow("Broker.link","Broker.link",0,0,"0 B",0,"");</script>
<script>addRow("Web_Users_Click_Here.html","Web_Users_Click_Here.html",0,468,"468
B",0,"");</script>
<script>addRow("alm_support","alm_support",1,0,"0 B",0,"");</script>
<script>addRow("armdl-test.txt","armdl-test.txt",0,24,"24 B",0,"");</script>
<script>addRow("bin","bin",0,0,"0 B",0,"");</script>
<script>addRow("dev","dev",1,0,"0 B",0,"");</script>
<script>addRow("ftp","ftp",0,0,"0 B",0,"");</script>
<script>addRow("lbtest.txt","lbtest.txt",0,2809,"2.7 kB",0,"");</script>
<script>addRow("lib","lib",1,0,"0 B",0,"");</script>
<script>addRow("license.txt","license.txt",0,2809,"2.7 kB",0,"");</script>
<script>addRow("pub","pub",1,0,"0 B",0,"");</script>
<script>addRow("pushtest","pushtest",0,14,"14 B",0,"");</script>
<script>addRow("signon.txt","signon.txt",0,431,"431 B",0,"");</script>
<script>addRow("usr","usr",1,0,"0 B",0,"");</script>
,
Aug 25 2016
,
Aug 25 2016
Lowering priority, since it's an FTP issue.
,
Aug 25 2016
Not blink.
,
Aug 26 2016
Interesting, I built chromium from the upstream and all the dates all OK. I can see May 20 2005 00:00 Directory Acrobat. The date is the same as Mark's.
,
Aug 26 2016
Ubuntu 16.04 LTS 64-bit. master@{#414425}
,
Aug 26 2016
Or wait, time is not correct.
,
Aug 26 2016
Able to repro this issue only on Ubuntu Trusty (14.04) for the Google Chrome Beta Version - 53.0.2785.80 This is a regression issue broken in M53, below mentioned is the bisect info: CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/f86d8b99516a12673d852b553d55c7b463009155..6d58939f2253f0686141508c07c666a092e5b2a2 Suspecting Commit: 558f168054566ecbc611918093398add04dc13a4 Review URL: https://codereview.chromium.org/1988663002 @maksim.sisov / eroman: Could you please look into the issue, and if it has nothing to do with your changes and if possible please do assign it to the concerned owner. Thank you.
,
Aug 26 2016
I just want to add that I also tried the latest Chromium continuous build yesterday, 414400 or so, and it had the same problem. So it appears to narrow down to Ubuntu 14.04 only.
,
Nov 17 2016
Sorry for taking so long to investigate! OK, so I finally got around to it today, and this appears to be a Linux-specific problem with how mktime() works under the sandbox -- issue 666535. This got tickled by commit 558f168054566ecbc611918093398add04dc13a4 which now surfaces this mis-parses as failures rather than (incorrectly) returning GMT as it did before. If we can't get mktime() to work properly, then we can just return to using UTC for the FTP dates, as was effectively the case prior to the regression.
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27f05072359d1862332f695ef9530f5f19da8b76 commit 27f05072359d1862332f695ef9530f5f19da8b76 Author: eroman <eroman@chromium.org> Date: Thu Dec 08 21:27:15 2016 Use UTC rather than local time for interpreting FTP listing dates. Both approaches are wrong, as the actual timezone is unknown. The main advantage of using UTC time is that it avoids a bug on Linux (issue 666535). BUG= 641096 Review-Url: https://codereview.chromium.org/2558143003 Cr-Commit-Position: refs/heads/master@{#437346} [modify] https://crrev.com/27f05072359d1862332f695ef9530f5f19da8b76/net/ftp/ftp_directory_listing_parser_ls.cc [modify] https://crrev.com/27f05072359d1862332f695ef9530f5f19da8b76/net/ftp/ftp_directory_listing_parser_unittest.cc [modify] https://crrev.com/27f05072359d1862332f695ef9530f5f19da8b76/net/ftp/ftp_directory_listing_parser_unittest.h [modify] https://crrev.com/27f05072359d1862332f695ef9530f5f19da8b76/net/ftp/ftp_directory_listing_parser_vms.cc [modify] https://crrev.com/27f05072359d1862332f695ef9530f5f19da8b76/net/ftp/ftp_util.cc [modify] https://crrev.com/27f05072359d1862332f695ef9530f5f19da8b76/net/ftp/ftp_util_unittest.cc
,
Dec 8 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by maksim.s...@intel.com
, Aug 25 2016