New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641080 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 649503



Sign in to add a comment

Run the dEQP-GLES standalone ANGLE tests on the AMD bots

Project Member Reported by jmad...@chromium.org, Aug 25 2016

Issue description

With the new AMD cards, and focus on WebGL 2, we want to run the thorough dEQP tests on the specific GPU test targets that care about them: The ANGLE CQ, the GPU FYI bots, and the optional gpu tester bots.

We might not want to add the GLES3 tests until the new machines are ready to be used in swarming, since they're much slower.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55eeec4d2232473dfb79ca71c97a1131fdf56596

commit 55eeec4d2232473dfb79ca71c97a1131fdf56596
Author: jmadill <jmadill@chromium.org>
Date: Wed Aug 31 18:43:09 2016

Run dEQP-GLES2 tests on the new AMD R7 Win bot.

This bot is currently FYI-only, and adding the test
will allow us to add the correct suppresions in ANGLE.

BUG= 641080 
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2273393002
Cr-Commit-Position: refs/heads/master@{#415695}

[modify] https://crrev.com/55eeec4d2232473dfb79ca71c97a1131fdf56596/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/55eeec4d2232473dfb79ca71c97a1131fdf56596/testing/buildbot/chromium.gpu.fyi.json

Blocking: 649503
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01b12a365a3f04f97d9dadd3263c7760348b0740

commit 01b12a365a3f04f97d9dadd3263c7760348b0740
Author: jmadill <jmadill@chromium.org>
Date: Thu Oct 27 23:27:07 2016

gpu: Add duplicate AMD bot configs.

Many of the AMD configs were referring to themselves as ATI, which is
very out of date. Change this to AMD. Also update bot names as
required, and PCI device ids where needed.

This will require two more steps: one to update the build side
integration, and finally to remove the old configs.

BUG=639353, 649863 , 641080 
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2449163002
Cr-Commit-Position: refs/heads/master@{#428207}

[modify] https://crrev.com/01b12a365a3f04f97d9dadd3263c7760348b0740/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/01b12a365a3f04f97d9dadd3263c7760348b0740/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/130d87891c84466c4410d13e124b433d694e2acd

commit 130d87891c84466c4410d13e124b433d694e2acd
Author: jmadill <jmadill@chromium.org>
Date: Wed Nov 02 02:58:53 2016

Rename Windows and Mac AMD GPU bots.

These were sometimes calling the bots "ATI" when the name for the
past several years has been "AMD". This change lines up with the
src side-changes. Once it lands and the master is restarted, we
can remove the old bot configs in src.

BUG=639353,  649863 ,  641080 
R=kbr@chromium.org
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2467923002

[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/masters/master.chromium.gpu.fyi/slaves.cfg
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipe_modules/chromium_tests/trybots.py
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder.json
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder.json
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder__dbg_.json
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder.json
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder__dbg_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Linux_Release__AMD_R5_230_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Debug__AMD_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Release__AMD_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Win7_Release__AMD_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Debug__AMD_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Release__AMD_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Release__AMD_R5_230_.json

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adeb70eb00de392da98c8cd0239d7309cd694de8

commit adeb70eb00de392da98c8cd0239d7309cd694de8
Author: jmadill <jmadill@chromium.org>
Date: Fri Nov 11 01:22:35 2016

gpu: Remove duplicated AMD bot configs.

Now that we've got the new names successfully running, we can
remove the old configurations.

BUG=639353, 649863 , 641080 
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2492023002
Cr-Commit-Position: refs/heads/master@{#431440}

[modify] https://crrev.com/adeb70eb00de392da98c8cd0239d7309cd694de8/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/adeb70eb00de392da98c8cd0239d7309cd694de8/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/597826c59589969bc904e9287adcf2bc9cdcfccf

commit 597826c59589969bc904e9287adcf2bc9cdcfccf
Author: jmadill <jmadill@chromium.org>
Date: Thu Dec 08 21:38:43 2016

Run dEQP ES3 tests on Windows AMD bots.

It's important for ANGLE to be able to test both NVIDIA and AMD (our
Windows WebGL 2 conformance targets) standalone with dEQP
for correctness on ANGLE rolls and ANGLE try bots. This change will
add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots,
and the ANGLE CQ. The Optional tester is not included for now.

BUG= 641080 
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2510153002
Cr-Commit-Position: refs/heads/master@{#437354}

[modify] https://crrev.com/597826c59589969bc904e9287adcf2bc9cdcfccf/content/test/gpu/generate_buildbot_json.py

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbe37cf941cdb6eae5af2086830d5412524fc4e1

commit dbe37cf941cdb6eae5af2086830d5412524fc4e1
Author: jmadill <jmadill@chromium.org>
Date: Fri Dec 09 20:18:49 2016

Revert of Run dEQP ES3 tests on Windows AMD bots. (patchset #2 id:20001 of https://codereview.chromium.org/2510153002/ )

Reason for revert:
Looks like the generated json didn't get updated properly.

Original issue's description:
> Run dEQP ES3 tests on Windows AMD bots.
>
> It's important for ANGLE to be able to test both NVIDIA and AMD (our
> Windows WebGL 2 conformance targets) standalone with dEQP
> for correctness on ANGLE rolls and ANGLE try bots. This change will
> add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots,
> and the ANGLE CQ. The Optional tester is not included for now.
>
> BUG= 641080 
> R=kbr@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> NOTRY=true
>
> Committed: https://crrev.com/597826c59589969bc904e9287adcf2bc9cdcfccf
> Cr-Commit-Position: refs/heads/master@{#437354}

TBR=kbr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 641080 

Review-Url: https://codereview.chromium.org/2567793002
Cr-Commit-Position: refs/heads/master@{#437618}

[modify] https://crrev.com/dbe37cf941cdb6eae5af2086830d5412524fc4e1/content/test/gpu/generate_buildbot_json.py

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d1fbf1a9c5306487b71f75685bdaaba146b1ca9

commit 8d1fbf1a9c5306487b71f75685bdaaba146b1ca9
Author: jmadill <jmadill@chromium.org>
Date: Mon Dec 12 18:09:11 2016

Re-land dEQP ES3 tests on Windows ANGLE bots.

It's important for ANGLE to be able to test both NVIDIA and AMD (our
support Windows WebGL 2 conformance targets) standalone with dEQP
for correctness on ANGLE rolls and ANGLE try bots. This change will
add the dEQP-GLES3 tests with ANGLE to the Windows GPU.FYI bots, and
the ANGLE CQ. The Optional tester is not included for now.

Re-land with JSON added.

BUG= 641080 
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2566643003
Cr-Commit-Position: refs/heads/master@{#437900}

[modify] https://crrev.com/8d1fbf1a9c5306487b71f75685bdaaba146b1ca9/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/8d1fbf1a9c5306487b71f75685bdaaba146b1ca9/testing/buildbot/chromium.gpu.fyi.json

Status: Fixed (was: Assigned)
Blockedon: 649503
Blocking: -649503

Sign in to add a comment