New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641051 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Normalize shipping address before sending to merchant website.

Project Member Reported by rouslan@chromium.org, Aug 25 2016

Issue description

^^^
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be9290202c973b5be6da49150c8ce8eb0334ed93

commit be9290202c973b5be6da49150c8ce8eb0334ed93
Author: sebsg <sebsg@chromium.org>
Date: Wed Oct 05 15:04:14 2016

Normalizes the state and city of the selected address before sending the information to the merchant.

BUG= 641051 

Review-Url: https://codereview.chromium.org/2338283003
Cr-Commit-Position: refs/heads/master@{#423162}

[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/browser/BUILD.gn
[add] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/browser/autofill/android/DEPS
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/third_party/libaddressinput/BUILD.gn
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/third_party/libaddressinput/chromium/chrome_address_validator.cc
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/third_party/libaddressinput/chromium/chrome_address_validator.h
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc

Comment 2 by se...@chromium.org, Oct 6 2016

Labels: Merge-Request-54

Comment 3 by dimu@chromium.org, Oct 6 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.

Comment 4 by se...@chromium.org, Oct 6 2016

Cc: rouslan@chromium.org zkoch@chromium.org
Labels: -Merge-Review-54 Merge-Rejected-54
Merge rejected, this is a huge patch for new functionality late in the game.  Ping me if you have any concerns.

Comment 6 by se...@chromium.org, Oct 11 2016

Summary: Normalize shipping address before sending to merchant website. (was: Normalize shipping/billing address before sending to merchant website.)

Comment 7 by se...@chromium.org, Oct 11 2016

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be9290202c973b5be6da49150c8ce8eb0334ed93

commit be9290202c973b5be6da49150c8ce8eb0334ed93
Author: sebsg <sebsg@chromium.org>
Date: Wed Oct 05 15:04:14 2016

Normalizes the state and city of the selected address before sending the information to the merchant.

BUG= 641051 

Review-Url: https://codereview.chromium.org/2338283003
Cr-Commit-Position: refs/heads/master@{#423162}

[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/browser/BUILD.gn
[add] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/browser/autofill/android/DEPS
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/third_party/libaddressinput/BUILD.gn
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/third_party/libaddressinput/chromium/chrome_address_validator.cc
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/third_party/libaddressinput/chromium/chrome_address_validator.h
[modify] https://crrev.com/be9290202c973b5be6da49150c8ce8eb0334ed93/third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment