Long term ash should not depend upon content. Work has been done to have separate targets in ash that are with and with-out content. We should have separate test targets too, those that depend upon content and those that don't.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff1b30c1127c08a265e95f2b6cc60d65e8bd7e49 commit ff1b30c1127c08a265e95f2b6cc60d65e8bd7e49 Author: sky <sky@chromium.org> Date: Thu Aug 25 23:43:13 2016 Make BluetoothAdapterBlueZ::Init early out if shutdown If a test creates a BluetoothAdapterBlueZ, inits, then shuts it down it's entirely possible to get to BluetoothAdapterBlueZ::Init() after bluez::BluezDBusManager has been destroyed. This patch makes BluetoothAdapterBlueZ::Init early out in such a situation. BUG= 641026 TEST=none R=rkc@chromium.org Review-Url: https://codereview.chromium.org/2279853002 Cr-Commit-Position: refs/heads/master@{#414584} [modify] https://crrev.com/ff1b30c1127c08a265e95f2b6cc60d65e8bd7e49/device/bluetooth/bluez/bluetooth_adapter_bluez.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e commit 72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e Author: sky <sky@chromium.org> Date: Wed Aug 31 20:43:54 2016 Moves ash content specific tests into ash_content_unittests The vast majority of the tests don't need content, so having to build content all the time is a drain (especially on windows). BUG= 641026 TEST=test only changes R=jamescook@chromium.org, dpranke@chromium.org Review-Url: https://codereview.chromium.org/2296973002 Cr-Commit-Position: refs/heads/master@{#415743} [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/BUILD.gn [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/BUILD.gn [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/ash.gyp [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/content/display/screen_orientation_controller_chromeos_unittest.cc [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/mus/BUILD.gn [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/test/DEPS [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/test/ash_test_base.cc [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/test/ash_test_base.h [add] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/test/ash_test_environment.h [add] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/test/ash_test_environment_content.cc [add] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/test/ash_test_environment_content.h [add] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/test/ash_test_environment_default.cc [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/test/ash_test_helper.cc [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/test/ash_test_helper.h [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/test/ash_test_helper_unittest.cc [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/test/ash_test_views_delegate.cc [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/test/ash_test_views_delegate.h [add] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/ash/test/content/DEPS [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/chrome/test/BUILD.gn [add] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/chrome/test/base/ash_test_environment_chrome.cc [add] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/chrome/test/base/ash_test_environment_chrome.h [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/chrome/test/base/browser_with_test_window_test.cc [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/chrome/test/base/browser_with_test_window_test.h [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/components/exo/BUILD.gn [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/testing/buildbot/chromium.memory.json [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/testing/buildbot/chromium.win.json [modify] https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e/testing/buildbot/gn_isolate_map.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4feb9f49a25aadfd400798be8c767d8b272ac446 commit 4feb9f49a25aadfd400798be8c767d8b272ac446 Author: fgorski <fgorski@chromium.org> Date: Wed Aug 31 23:17:18 2016 Revert of Moves ash content specific tests into ash_content_unittests (patchset #7 id:120001 of https://codereview.chromium.org/2296973002/ ) Reason for revert: AshTestEnvironmentDefault::GetBlockingPool() never gets released causing memory leaks in tests: WallpaperControllerTest.DontScaleWallpaperWithCenterLayout WallpaperControllerTest.ResizeCustomWallpaper https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15788 https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15787 Original issue's description: > Moves ash content specific tests into ash_content_unittests > > The vast majority of the tests don't need content, so having to build > content all the time is a drain (especially on windows). > > BUG= 641026 > TEST=test only changes > R=jamescook@chromium.org, dpranke@chromium.org > > Committed: https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e > Cr-Commit-Position: refs/heads/master@{#415743} TBR=reveman@chromium.org,dpranke@chromium.org,jam@chromium.org,jamescook@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 641026 Review-Url: https://codereview.chromium.org/2303453003 Cr-Commit-Position: refs/heads/master@{#415797} [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/BUILD.gn [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/ash/BUILD.gn [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/ash/ash.gyp [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/ash/content/display/screen_orientation_controller_chromeos_unittest.cc [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/ash/mus/BUILD.gn [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/ash/test/DEPS [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/ash/test/ash_test_base.cc [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/ash/test/ash_test_base.h [delete] https://crrev.com/4d064b54d8a747c1400f88db62a0ac5df90b1cb4/ash/test/ash_test_environment.h [delete] https://crrev.com/4d064b54d8a747c1400f88db62a0ac5df90b1cb4/ash/test/ash_test_environment_content.cc [delete] https://crrev.com/4d064b54d8a747c1400f88db62a0ac5df90b1cb4/ash/test/ash_test_environment_content.h [delete] https://crrev.com/4d064b54d8a747c1400f88db62a0ac5df90b1cb4/ash/test/ash_test_environment_default.cc [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/ash/test/ash_test_helper.cc [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/ash/test/ash_test_helper.h [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/ash/test/ash_test_helper_unittest.cc [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/ash/test/ash_test_views_delegate.cc [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/ash/test/ash_test_views_delegate.h [delete] https://crrev.com/4d064b54d8a747c1400f88db62a0ac5df90b1cb4/ash/test/content/DEPS [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/chrome/test/BUILD.gn [delete] https://crrev.com/4d064b54d8a747c1400f88db62a0ac5df90b1cb4/chrome/test/base/ash_test_environment_chrome.cc [delete] https://crrev.com/4d064b54d8a747c1400f88db62a0ac5df90b1cb4/chrome/test/base/ash_test_environment_chrome.h [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/chrome/test/base/browser_with_test_window_test.cc [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/chrome/test/base/browser_with_test_window_test.h [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/components/exo/BUILD.gn [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/testing/buildbot/chromium.memory.json [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/testing/buildbot/chromium.win.json [modify] https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446/testing/buildbot/gn_isolate_map.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf094f679dc06e932a37eddecb35685f9a4ec8f8 commit cf094f679dc06e932a37eddecb35685f9a4ec8f8 Author: sky <sky@chromium.org> Date: Thu Sep 01 19:40:12 2016 Moves ash content specific tests into ash_content_unittests The vast majority of the tests don't need content, so having to build content all the time is a drain (especially on windows). BUG= 641026 TEST=test only changes R=jamescook@chromium.org, dpranke@chromium.org Committed: https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e Review-Url: https://codereview.chromium.org/2296973002 Cr-Original-Commit-Position: refs/heads/master@{#415743} Cr-Commit-Position: refs/heads/master@{#416019} [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/BUILD.gn [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/BUILD.gn [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/ash.gyp [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/content/display/screen_orientation_controller_chromeos_unittest.cc [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/mus/BUILD.gn [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/test/DEPS [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/test/ash_test_base.cc [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/test/ash_test_base.h [add] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/test/ash_test_environment.h [add] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/test/ash_test_environment_content.cc [add] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/test/ash_test_environment_content.h [add] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/test/ash_test_environment_default.cc [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/test/ash_test_helper.cc [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/test/ash_test_helper.h [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/test/ash_test_helper_unittest.cc [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/test/ash_test_views_delegate.cc [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/test/ash_test_views_delegate.h [add] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/ash/test/content/DEPS [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/chrome/test/BUILD.gn [add] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/chrome/test/base/ash_test_environment_chrome.cc [add] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/chrome/test/base/ash_test_environment_chrome.h [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/chrome/test/base/browser_with_test_window_test.cc [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/chrome/test/base/browser_with_test_window_test.h [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/components/exo/BUILD.gn [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/testing/buildbot/chromium.memory.json [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/testing/buildbot/chromium.win.json [modify] https://crrev.com/cf094f679dc06e932a37eddecb35685f9a4ec8f8/testing/buildbot/gn_isolate_map.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abc167aee99d4f7a20452064b2ca3ab9ed7c6ff3 commit abc167aee99d4f7a20452064b2ca3ab9ed7c6ff3 Author: sky <sky@chromium.org> Date: Wed Sep 07 00:57:45 2016 Splits ash_test_resources_100_percent into two pak files One depends upon content, the other doesn't. This way ash_unittests doesn't depend upon anything in content. BUG= 641026 TEST=test only changes R=msw@chromium.org Review-Url: https://codereview.chromium.org/2316803002 Cr-Commit-Position: refs/heads/master@{#416808} [modify] https://crrev.com/abc167aee99d4f7a20452064b2ca3ab9ed7c6ff3/ash/BUILD.gn [modify] https://crrev.com/abc167aee99d4f7a20452064b2ca3ab9ed7c6ff3/ash/resources/BUILD.gn [modify] https://crrev.com/abc167aee99d4f7a20452064b2ca3ab9ed7c6ff3/ash/shell/content/client/shell_main_delegate.cc [modify] https://crrev.com/abc167aee99d4f7a20452064b2ca3ab9ed7c6ff3/ash/test/ash_test_environment.h [modify] https://crrev.com/abc167aee99d4f7a20452064b2ca3ab9ed7c6ff3/ash/test/ash_test_environment_content.cc [modify] https://crrev.com/abc167aee99d4f7a20452064b2ca3ab9ed7c6ff3/ash/test/ash_test_environment_default.cc [modify] https://crrev.com/abc167aee99d4f7a20452064b2ca3ab9ed7c6ff3/ash/test/test_suite.cc
Comment 1 by bugdroid1@chromium.org
, Aug 25 2016