New issue
Advanced search Search tips

Issue 641006 link

Starred by 1 user
Status: Fixed
Owner:
rdevlin....@chromium.org
Closed: Aug 2016
Cc:
lazyboy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 636655
issue 640247



Sign in to add a comment

Extension Schema Bundle Generator unnecessarily creates a list object

Project Member Reported by rdevlin....@chromium.org, Aug 25 2016 
When generating the schema bundle, we create a list object for each schema, containing exactly one element.  We should just create a single object and update parsing code.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b78360333968100cfee4ef50be21ee6f5d8d243

commit 3b78360333968100cfee4ef50be21ee6f5d8d243
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Thu Aug 25 20:48:17 2016

[Extensions] Don't generate a list for each generated schema

Currently, we generate a list of exactly one element for each generated
schema. This simplifies it to just generate an object.

BUG= 641006 

Review-Url: https://codereview.chromium.org/2275063002
Cr-Commit-Position: refs/heads/master@{#414531}

[modify] https://crrev.com/3b78360333968100cfee4ef50be21ee6f5d8d243/extensions/common/extension_api.cc
[modify] https://crrev.com/3b78360333968100cfee4ef50be21ee6f5d8d243/tools/json_schema_compiler/cpp_bundle_generator.py

Comment 2 by rdevlin....@chromium.org, Aug 25 2016

Status: Fixed (was: Started)
►

Sign in to add a comment