"analyze: No compile necessary" but compiles anyway for blink tests |
|||||
Issue descriptionhttps://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/281143 The analyze step says analyze output: { "compile_targets": [], "status": "No dependency", "test_targets": [] } and analyze analyze No compile necessary Yet, this is clearly compiling something. Did something break?
,
Aug 25 2016
,
Jan 5 2017
,
Jan 5 2017
Fixing this will involve removing the special logic for layout tests which is at: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?l=963.
,
Jan 6 2017
We don't need to remove all of the special logic. It's more a bug that we're not respecting the analyze results here. Moving to swarming the layout tests will fix this, but it's easy enough to fix this in the meantime, too.
,
Jun 7 2017
With layout tests on swarming being rolled out, this is pretty much in the process of being fixed. The only case where this is still happening is where BlinkTest is manually added to the builder in the config. When the BlinkTest object is removed this will no longer be happening.
,
Sep 6 2017
With LayoutTests on Swarming running everywhere, this should be fixed. There might still be some minor cases where this still occurs but they will soon be removed as the special case logic is removed in the next couple of weeks. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dpranke@chromium.org
, Aug 25 2016Summary: "analyze: No compile necessary" but compiles anyway for blink tests (was: "analyze: No compile necessary" but compiles anyway)