No way to login with an existing account when offline |
|||||||||
Issue descriptionSynced on this with cyrusm@ and kuscher@. This is a blocker for a current 1.2M device tender in Mexico. Therefore P1. *Description* No way to login with an *existing* account in the following scenario: 1. Offline 2. Pods enabled. See: "Always show username and photos" https://screenshot.googleplex.com/p4QO3DAdigH.png 3. Account not shown in the UI cause too many accounts to display in the screen However, when pods are disabled there's a way to login with an existing account. See: https://screenshot.googleplex.com/jmKsbOEcPdZ.png *Repro steps* 1. Enable pods from cpanel. See: https://screenshot.googleplex.com/p4QO3DAdigH.png 2. Add multiple users until the UI is full 3. Go offline 4. Try to log in with a user that is not in the UI by clicking on "Add person" Result: "sign in as an existing user" doesn't appear Expected: "sign in as an existing user" appears. This works well with pods disabled. See: https://screenshot.googleplex.com/jmKsbOEcPdZ.png To clarify - is this just a UI issue - i.e. we don't show a link that says 'sign in as existing user' but if you click add user, go through the flow, and login, it *should* at least bring up your old existing partition on the device. Can we verify if this is the case. It's my understanding that, yes, the UI should be fixed but I don't know if the underlying code is broken or not. Also, it's unclear to me what the best UI is here - I don't think user should have to click 'add user' if pods are not shown since that's not really what they want to do - they simply want to login. Before we make any fixes, can we please see the proposed UI / flow / fix? --- Comment from Kuscher: @Cyrus/Miguel is M54 or M55 your timeframe (as in, latest date)
,
Aug 25 2016
,
Aug 25 2016
I believe that I've verified this as a UI issue only, via the following: - With pods enabled, added users until several fell off the sign in screen. - Turn off Wi-Fi, and the "sign in as existing user" option is absent. - Keeping Wi-Fi off, log in as owner and disable pods. - "Sign in as existing user" option is now available, and I can sign into the users that fell off with pods. I imagine the quick fix here is simply to display the "sign-in as existing user" option when pods are enabled, although I agree the current flow of clicking "Add user" to login to an existing user could be improved. Albert, Alexander, is there a reason why we currently do not display "sign in as existing user" when pods are enabled?
,
Aug 25 2016
Discussed offline, for 54 let's make the change to always display "sign-in as existing user" on the Add new user dialog, even when pods are enabled. We should continue thinking about how to improve this flow for future releases. @glevin, Albert asked me to send this your way, let me know however I can help!
,
Aug 30 2016
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2b7b5a5d5bde185d6c1f803919ed551676ba6b6 commit a2b7b5a5d5bde185d6c1f803919ed551676ba6b6 Author: glevin <glevin@chromium.org> Date: Fri Sep 02 17:38:34 2016 Better access to offline login flow from user pods BUG= 641001 TEST=With device off-line, click Add person, check that "sign in as an existing user" link is at the bottom of the "Network not available" page, and sign in using this link. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2298073003 Cr-Commit-Position: refs/heads/master@{#416295} [modify] https://crrev.com/a2b7b5a5d5bde185d6c1f803919ed551676ba6b6/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/a2b7b5a5d5bde185d6c1f803919ed551676ba6b6/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
,
Sep 2 2016
,
Sep 3 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2aa35f4ede6094776c9e6849079195a1623c79a commit e2aa35f4ede6094776c9e6849079195a1623c79a Author: glevin <glevin@chromium.org> Date: Tue Sep 06 14:11:36 2016 Better access to offline login flow from user pods BUG= 641001 TEST=With device off-line, click Add person, check that "sign in as an existing user" link is at the bottom of the "Network not available" page, and sign in using this link. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2298073003 Cr-Commit-Position: refs/heads/master@{#416295} (cherry picked from commit a2b7b5a5d5bde185d6c1f803919ed551676ba6b6) Review URL: https://codereview.chromium.org/2312913002 . Cr-Commit-Position: refs/branch-heads/2840@{#167} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/e2aa35f4ede6094776c9e6849079195a1623c79a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/e2aa35f4ede6094776c9e6849079195a1623c79a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
,
Sep 6 2016
,
Oct 12 2016
Verified 54.0.2840.51/8743.57.0
,
Oct 12 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2aa35f4ede6094776c9e6849079195a1623c79a commit e2aa35f4ede6094776c9e6849079195a1623c79a Author: glevin <glevin@chromium.org> Date: Tue Sep 06 14:11:36 2016 Better access to offline login flow from user pods BUG= 641001 TEST=With device off-line, click Add person, check that "sign in as an existing user" link is at the bottom of the "Network not available" page, and sign in using this link. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2298073003 Cr-Commit-Position: refs/heads/master@{#416295} (cherry picked from commit a2b7b5a5d5bde185d6c1f803919ed551676ba6b6) Review URL: https://codereview.chromium.org/2312913002 . Cr-Commit-Position: refs/branch-heads/2840@{#167} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/e2aa35f4ede6094776c9e6849079195a1623c79a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/e2aa35f4ede6094776c9e6849079195a1623c79a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by kuscher@chromium.org
, Aug 25 2016