As I understand it, the error GoogleServiceAuthError::HOSTED_NOT_ALLOWED... https://cs.chromium.org/chromium/src/google_apis/gaia/google_service_auth_error.h?q=HOSTED_NOT_ALLOWED&sq=package:chromium&l=79&dr=CSs https://cs.chromium.org/search/?q=HOSTED_NOT_ALLOWED&sq=package:chromium&type=cs ...may no longer be a possible error condition, as Hosted Accounts are no longer used. We need to 1) verify that this error condition is no longer possible, and if so, 2) remove it from the code anywhere that won't break an enumeration. alemate@ - Could you provide more insight into this error, and/or cc someone on this bug who might know more about it? Thanks!
Yes, I think we can remove this completely.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23fbe6681a7125701034c6d3fbff6671f6fb8f6a commit 23fbe6681a7125701034c6d3fbff6671f6fb8f6a Author: glevin <glevin@chromium.org> Date: Sat Sep 10 22:37:11 2016 Deprecate HOSTED_NOT_ALLOWED auth error BUG= 640958 TEST=Just a code cleanup, shouldn't change any behavior. Review-Url: https://codereview.chromium.org/2314913003 Cr-Commit-Position: refs/heads/master@{#417847} [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/chrome/android/java/src/org/chromium/chrome/browser/sync/GoogleServiceAuthError.java [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/chrome/browser/chromeos/login/existing_user_controller.cc [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/chrome/browser/chromeos/login/help_app_launcher.h [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/chrome/browser/chromeos/login/ui/webui_login_display.cc [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/chrome/browser/signin/signin_error_notifier_ash_unittest.cc [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/chrome/browser/signin/signin_global_error_unittest.cc [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/chrome/browser/sync/sync_ui_util_unittest.cc [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/components/signin/core/browser/signin_error_controller_unittest.cc [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/google_apis/gaia/google_service_auth_error.cc [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/google_apis/gaia/google_service_auth_error.h [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/ios/chrome/browser/sync/sync_setup_service.cc [modify] https://crrev.com/23fbe6681a7125701034c6d3fbff6671f6fb8f6a/tools/metrics/histograms/histograms.xml
Comment 1 by alemate@chromium.org
, Sep 3 2016