default_for_enterprise_users in policy_templates.json should work for all platforms |
||||||
Issue descriptionCurrently default_for_enterprise_users attribute only affects chrome os, but it should work on all cloud policy platforms. This attribute was added in https://codereview.chromium.org/519643002. We should: 1) Change generate_policy_source.py to remove the CHROME_OS-only ifdefs around the generated code. 2) Change cloud_policy_browsertest.cc to similarly remove CHROME_OS-only ifdef around the GetExpectedDefaultPolicy() API. 3) Move the code in UserCloudPolicyManagerChromeOS::GetChromePolicy() into UserCloudPolicyManager instead.
,
Aug 26 2016
,
Aug 29 2016
Pending CL (which doesn't build because of dependency issues in the build files for components/policy): https://codereview.chromium.org/2275963004/
,
Oct 28 2016
I guess this bug explains why there's an "NTPContentSuggestionsEnabled" policy is set on Chrome OS (and probably other platforms)? It's displayed at chrome://policy with status "Unknown policy." and produces a log message: "ERROR:configuration_policy_handler_list.cc(92)] Unknown policy: NTPContentSuggestionsEnabled"
,
Oct 28 2016
I guess so, yes - probably the "Unknown policy" is because the policy is marked as supported on Android only. https://codereview.chromium.org/2282743002 introduced setting the policy by default, I guess we could just put an #if defined(OS_ANDROID) around that code block. Or, if this bug is properly fixed, that might also solve it.
,
Oct 30 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 29 2018
,
Apr 2 2018
Is this still relevant? I'm trying to find more info about default_for_enterprise_users, but the CL's description is not helpful :( https://codereview.chromium.org/519643002
,
Apr 2 2018
Here's treib@'s attempt from last year at adding support for Android: https://codereview.chromium.org/2275963004/ Anyhow, probably not *that* relevant since most of the policies in policy_templats.json with this attribute are cros-only. I think we could safely WontFix this.
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f71e60d2c1b41c1c28c8e5276223b0d6242a1899 commit f71e60d2c1b41c1c28c8e5276223b0d6242a1899 Author: Owen Min <zmin@chromium.org> Date: Fri Jun 29 22:10:29 2018 Remove NTPContentSuggestionsEnabled as default from non android platform. Remove it before SetEnterpriseDefault being implemented for all platforms to avoid ugly unknown policy error. Bug: 640950 Change-Id: I3affe39bc52f5ff003d14ac038be75ac81c25dce Reviewed-on: https://chromium-review.googlesource.com/1115598 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571667} [modify] https://crrev.com/f71e60d2c1b41c1c28c8e5276223b0d6242a1899/chrome/browser/policy/cloud/cloud_policy_test_utils.cc [modify] https://crrev.com/f71e60d2c1b41c1c28c8e5276223b0d6242a1899/components/policy/core/common/cloud/user_cloud_policy_manager.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by treib@chromium.org
, Aug 25 2016Owner: treib@chromium.org
Status: Started (was: Untriaged)