New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640929 link

Starred by 2 users
Status: Verified
Owner:
varkha@chromium.org
Closed: Aug 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ bshe@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Grey background is seen missing on rotating screen when in overview mode

Project Member Reported by sc00335...@techmahindra.com, Aug 25 2016 
Version: 53.0.2785.81/8530.69.0 (Official Build) beta-channel daisy,Peppy,Blaze
OS: Chrome os

What steps will reproduce the problem?
(1) Open any window in overview mode and observe grey background >> Rotate screen using ctrl+shift+reload and observe for grey background

Expected: Grey background should remain even after rotating display.
Actual: Instead grey background vanishes on rotating.

This is a non-regression issue.

@varkha: Please confirm the issue.

Attaching screenshots for reference
After rotating.png
343 KB View Download
Before rotating.png
174 KB View Download

Comment 1 by kavvaru@chromium.org, Aug 25 2016 

Able to reproduce the issue on Peppy using chrome version 53.0.2785.81/8530.69.

Comment 2 by varkha@chromium.org, Aug 25 2016

Cc: bshe@chromium.org
Status: Started (was: Assigned)
Yes, the reason for this is that the wallpaper is updated asynchronously and just responding to OnDisplayMetricsChanged() is not enough because the delayed wallpaper update is causing re-parenting and breaks the stacking order 100ms later.
I have a fix that maintains the wallpaper's DesktopBackgroundView to stay at the bottom in its container at https://codereview.chromium.org/2278903003/.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fae847c2b1a45bc248e33bf29db361dd13fcf47

commit 6fae847c2b1a45bc248e33bf29db361dd13fcf47
Author: varkha <varkha@chromium.org>
Date: Thu Aug 25 21:09:13 2016

[ash-md] Keeps overview mode shield above DesktopBackgroundView

Reparenting the background widgets modifies the stacking order. This CL
restores the intended order by updating the stacking in Layout().

BUG= 640929 

Review-Url: https://codereview.chromium.org/2278903003
Cr-Commit-Position: refs/heads/master@{#414537}

[modify] https://crrev.com/6fae847c2b1a45bc248e33bf29db361dd13fcf47/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/6fae847c2b1a45bc248e33bf29db361dd13fcf47/ash/common/wm/overview/window_selector.cc
[modify] https://crrev.com/6fae847c2b1a45bc248e33bf29db361dd13fcf47/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/6fae847c2b1a45bc248e33bf29db361dd13fcf47/ash/desktop_background/desktop_background_view.cc

Comment 4 by varkha@chromium.org, Aug 25 2016

Labels: Proj-MaterialDesign-CrOS
Status: Fixed (was: Started)

Comment 5 by pbath...@chromium.org, Sep 28 2016

Status: Verified (was: Fixed)
verified on 54.0.2840.42
►

Sign in to add a comment