New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640921 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Sign in to add a comment

Mass cleanup of unmapped histograms

Project Member Reported by ricea@chromium.org, Aug 25 2016

Issue description

There are currently 270 histograms which appear in the source but do not appear in histograms.xml. The data from these histograms is not useful and in general they should be removed.

The plan is to file bugs for groups of histograms which have the same prefix. Owner information will be deduced based on git blame.

This is a tracking bug to be blocked on individual bugs to be filed automatically.
 

Comment 1 by ricea@chromium.org, Aug 26 2016

Blockedon: 641289

Comment 2 by ricea@chromium.org, Aug 30 2016

Blockedon: 642278

Comment 3 by ricea@chromium.org, Aug 30 2016

Blockedon: 642281

Comment 4 by ricea@chromium.org, Aug 30 2016

Blockedon: 642282

Comment 5 by ricea@chromium.org, Aug 30 2016

Blockedon: 642283

Comment 6 by ricea@chromium.org, Aug 30 2016

Blockedon: 642284

Comment 7 by ricea@chromium.org, Aug 30 2016

Blockedon: 642285

Comment 8 by ricea@chromium.org, Aug 30 2016

Blockedon: 642286

Comment 9 by ricea@chromium.org, Aug 30 2016

Blockedon: 642287

Comment 10 by ricea@chromium.org, Aug 30 2016

Blockedon: 642288

Comment 11 by ricea@chromium.org, Aug 30 2016

Blockedon: 642289

Comment 12 by ricea@chromium.org, Aug 31 2016

Blockedon: 642621

Comment 13 by ricea@chromium.org, Aug 31 2016

Blockedon: 642622

Comment 14 by ricea@chromium.org, Aug 31 2016

Blockedon: 642623

Comment 15 by ricea@chromium.org, Aug 31 2016

Blockedon: 642624

Comment 16 by ricea@chromium.org, Aug 31 2016

Blockedon: 642625

Comment 17 by ricea@chromium.org, Aug 31 2016

Blockedon: 642626

Comment 18 by ricea@chromium.org, Aug 31 2016

Blockedon: 642627

Comment 19 by ricea@chromium.org, Aug 31 2016

Blockedon: 642628

Comment 20 by ricea@chromium.org, Aug 31 2016

Blockedon: 642629

Comment 21 by ricea@chromium.org, Aug 31 2016

Blockedon: 642630

Comment 22 by ricea@chromium.org, Aug 31 2016

After removing histograms included in the internal histograms.xml, there are now "only" 130 that are not mapped.
Blockedon: 643520
Blockedon: 643521
Blockedon: 643522
Blockedon: 643523
Blockedon: 643525
Blockedon: 643526
Blockedon: 643527
Blockedon: 643528
Blockedon: 643529
Blockedon: 643530
Blockedon: 643531
Blockedon: 643532
Blockedon: 643533
Blockedon: 643534
Blockedon: 643535
Blockedon: 643536
Blockedon: 643537
Blockedon: 643538
Blockedon: 643539
Blockedon: 643540
Blockedon: 643541
Blockedon: 643542
Blockedon: 643543
Blockedon: 643544
Blockedon: 643545
Blockedon: 643546
Blockedon: 643547
Blockedon: 643548
Blockedon: 643549
Blockedon: 643550
Blockedon: 643551
Blockedon: 643552
Blockedon: 643553
Blockedon: 643554
Blockedon: 643555
Blockedon: 643556
Blockedon: 643557
Blockedon: 643558
Blockedon: 643559
Blockedon: 643560
Blockedon: 643561
Blockedon: 643562
Blockedon: 643563
Blockedon: 643564
Blockedon: 643565
Blockedon: 643566
Blockedon: 643567
Blockedon: 643568
Blockedon: 643569
Blockedon: 643570
Blockedon: 643571
Blockedon: 643572
Blockedon: 643573
Blockedon: 643574
Blockedon: 643575
Are you still working on this?

Comment 79 by ricea@chromium.org, Oct 27 2016

Not actively. I'm just using this as a tracking bug. Since the bugs are also in a hotlist, I can close this issue if you prefer.
I would recommend at least going through the bugs you filed and make sure the owners are still active on Chromium.

Comment 81 by ricea@chromium.org, Apr 21 2017

Sorry for the trouble. I just made a pass through and reassigned ones with inactive owners.

Comment 82 by ricea@chromium.org, Apr 21 2017

Status: Assigned (was: Started)
Cc: isherman@chromium.org
 Issue 387734  has been merged into this issue.
Blockedon: 828189
Blockedon: 828188
Project Member

Comment 86 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6543db89e2515c2f6ffb6cd58a07f603327cd44

commit b6543db89e2515c2f6ffb6cd58a07f603327cd44
Author: Mike Wittman <wittman@chromium.org>
Date: Fri May 18 23:57:44 2018

[Eraser] Remove Net.QuicClock.SkewOffset histogram

This was never added to histograms.xml, which means the data has never
been viewed on the dashboards. It's also among the top 10 unmapped
histograms by data size.

Since this was never used, this CL simply removes it.  There is no
reason to spend resources to record it.

BUG: 640921
Change-Id: I8d665d8797d6d7b8cbc69e7d64a3e390c89fa7df
Reviewed-on: https://chromium-review.googlesource.com/1066775
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560108}
[modify] https://crrev.com/b6543db89e2515c2f6ffb6cd58a07f603327cd44/net/quic/chromium/quic_clock_skew_detector.cc

Sign in to add a comment