Regression : In md-history page, focus on 'SIGN IN TO CHROME’ button is not visible.
Reported by
yfulgaon...@etouch.net,
Aug 25 2016
|
||||
Issue descriptionChrome Version : 54.0.2839.0 (Official Build) 911ba12253b14bfe874a321c57031f5ac534ce31-refs/heads/master@{#414243} (64-bit) OS: Mac(10.10.5)(10.11.5) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://history page. 2. Click on ‘Tabs from other..’ and press Tab key to move focus on ’SIGN IN TO CHROME’ button, observe. Actual : Focus on ’SIGN IN TO CHROME’ button is not visible. Expected : Focus on ’SIGN IN TO CHROME’ button should be visible. This is a regression issue broken in M-54, below is the Manual Regression and will soon update other info. Good build: 54.0.2838.0 Bad build: 54.0.2839.0
,
Aug 25 2016
Narrow Bisect : https://chromium.googlesource.com/chromium/src/+log/d95e6aa7ad7027c7acbe706099f56734562eaa01..1430d329f356914f91ebae7ec4542524ceccf173?pretty=fuller&n=10000 Suspecting: r413983 from narrow bisect.
,
Aug 25 2016
Adding release block label, please undo if not the case.
,
Aug 30 2016
tsergeant@: Could you please take a look at this and review the blocker label. Thank you!
,
Aug 30 2016
There's a fix on the way, but this doesn't need to block M54 since MD History is not launching in that version.
,
Sep 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1615aabb99d99095e997bc6b6cd8c15caa7fdd2f commit 1615aabb99d99095e997bc6b6cd8c15caa7fdd2f Author: tsergeant <tsergeant@chromium.org> Date: Mon Sep 05 00:47:44 2016 MD History: Fix focus highlight on 'Sign in to Chrome' button This changes the button to use the shared action-button style, which makes the focus styling consistent with other material WebUIs. BUG= 640908 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2288033002 Cr-Commit-Position: refs/heads/master@{#416482} [modify] https://crrev.com/1615aabb99d99095e997bc6b6cd8c15caa7fdd2f/chrome/browser/resources/md_history/app.vulcanized.html [modify] https://crrev.com/1615aabb99d99095e997bc6b6cd8c15caa7fdd2f/chrome/browser/resources/md_history/synced_device_manager.html
,
Sep 11 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 Deleted