New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640893 link

Starred by 2 users
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Weird behavior of spinner is seen on chrome://downloads/

Reported by dmascare...@etouch.net, Aug 25 2016 
Version:54.0.2839.0 (Official Build) 911ba12253b14bfe874a321c57031f5ac534ce31-refs/heads/master@{#414243} 64 bit
OS: Mac (10.10.5,10.11.4)

What steps will reproduce the problem?
1. Launch chrome and and navigate to chrome://downloads/ page 
2. Click on search field,enter any word and hit spacebar (‘abc  ’)
3. Observe the spinner.

Actual: Continuously loading spinner is seen after step 2.
Expected: Continuously loading spinner should not be seen .
         
This is regression issue, broken in ‘M 54’ and below is the bisect info:

Good build:54.0.2838.0
Bad build:54.0.2839.0

Narrow bisect :
https://chromium.googlesource.com/chromium/src/+log/86cd3c83cb2b2c50774aeb706c69c83665d5cd67..732fed24791b89066a425a7ce097b0d9e5025c4c?pretty=fuller&n=1000

Suspecting: r414022

Note: Will soon update the Windows and Linux OS info.
Actual_download.mp4
548 KB View Download

Comment 1 by ranjitkan@chromium.org, Aug 25 2016

Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 2 by dbeam@chromium.org, Aug 25 2016

Status: Started (was: Assigned)

Comment 4 by dbeam@chromium.org, Aug 29 2016

Status: Fixed (was: Started)

Comment 5 by dbeam@chromium.org, Aug 29 2016

Labels: Merge-Request-54
this fix barley missed the branch

Comment 6 by dimu@chromium.org, Aug 29 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3

commit 3fe68ce49e15112e888c77e0ef0b27b026a7f2b3
Author: Dan Beam <dbeam@chromium.org>
Date: Tue Aug 30 00:46:59 2016

Merge: MD Downloads: fix search spinner when terms are the same

R=tsergeant@chromium.org
BUG= 640893 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2284463002
Cr-Commit-Position: refs/heads/master@{#414643}
(cherry picked from commit ad86c212a9e1b3d608c99a3d903da1cbfc1e74df)

Review URL: https://codereview.chromium.org/2289013002 .

Cr-Commit-Position: refs/branch-heads/2840@{#27}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/browser/resources/md_downloads/action_service.js
[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/browser/resources/md_downloads/action_service_unittest.gtestjs
[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/browser/resources/md_downloads/toolbar.js
[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/test/data/webui/md_downloads/toolbar_tests.js
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3

commit 3fe68ce49e15112e888c77e0ef0b27b026a7f2b3
Author: Dan Beam <dbeam@chromium.org>
Date: Tue Aug 30 00:46:59 2016

Merge: MD Downloads: fix search spinner when terms are the same

R=tsergeant@chromium.org
BUG= 640893 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2284463002
Cr-Commit-Position: refs/heads/master@{#414643}
(cherry picked from commit ad86c212a9e1b3d608c99a3d903da1cbfc1e74df)

Review URL: https://codereview.chromium.org/2289013002 .

Cr-Commit-Position: refs/branch-heads/2840@{#27}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/browser/resources/md_downloads/action_service.js
[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/browser/resources/md_downloads/action_service_unittest.gtestjs
[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/browser/resources/md_downloads/toolbar.js
[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3/chrome/test/data/webui/md_downloads/toolbar_tests.js
►

Sign in to add a comment