Issue metadata
Sign in to add a comment
|
Regression : Weird flickering of contents is seen after closing 'Clear browsing data' overlay in chrome://settings/ page.
Reported by
mni...@etouch.net,
Aug 25 2016
|
||||||||||||||||||||||
Issue descriptionVersion: 54.0.2838.0 2ef45ff9caf531d43a366186a7c80d7307d91252-refs/heads/master@{#413929} (64-bit) OS: Mac OS X(10.11.4) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://history/ 2. Now click on 'Clear browsing data' which navigates to chrome://settings/clearBrowserData 3. Now click on close button 'X' of 'Clear browsing data' overlay and observe the check boxes and contents under 'Settings' Actual: Weird flickering of check boxes and content is seen after closing 'Clear browsing data' overlay. Expected: Weird flickering of check boxes and content should not be seen after closing 'Clear browsing data' overlay. This is regression issue, broken in ‘M 52’ and below is manual regression and narrow bisect info: Good build : 52.0.2740.0 Bad build : 52.0.2741.0 Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/dc0bb630f6f47f0cfc8fabc62261dea818ad3cbe..db283d697decb9f16e1eb08f5d37305e05a6234b?pretty=fuller&n=1000 Suspecting: r394430 from Narrow bisect @shrike : Could you please help to reassign if your change is not the cause for this change. Note : Issue is not seen on Linux,Windows and Mac OS(10.10.5).
,
Aug 25 2016
,
Aug 30 2016
are you /sure/ this is the right bisect? if so, maybe the skia roll did this
,
Aug 30 2016
With response to comment #3 : Rechecked again on different machine and getting same bisect range as given above. Suspecting: r394431 ? Please help to re-assign if your change is not the cause for this issue.
,
Aug 30 2016
I manually bisected this to this CL: https://chromium.googlesource.com/chromium/src/+log/dc0bb630f6f47f0cfc8fabc62261dea818ad3cbe..db283d697decb9f16e1eb08f5d37305e05a6234b?pretty=fuller&n=1000
,
Aug 30 2016
This is a range, not a particular cl. A change to the top chrome would not affect checkbox controls inside of web content.
,
Aug 30 2016
Sorry, I pasted the wrong link. It is this CL: https://chromium.googlesource.com/chromium/src/+/a128b79566a12f910fda7acfb9ee671c8dbd2705
,
Aug 30 2016
,
Aug 30 2016
By manually bisected are you saying that you built a version of Chrome with that CL reverted and you were unable to reproduce the problem?
,
Aug 30 2016
Yes. I built with and without the CL. It repros with the CL and not without.
,
Aug 30 2016
The problem does indeed manifest as a result of the toolbar cl, specifically the change to -baseToolbarHeight in toolbar_controller.mm. It's very odd that a portion of web content would shift position based on a toolbar change - dbeam@, any idea how that could happen? I note that the checkbox boxes (and perhaps the other controls) are 1pt too low on the page relative to the checkbox titles after the shift. With my change backed out the boxes are also too low relative to their titles (they just don't shift down after clicking the close box). This is a bug with the old Settings page. How much is it worth investigating and fixing given that MD Settings is imminent?
,
Aug 30 2016
shrike@: I almost guarantee you this isn't just an issue with settings, but more likely an issue with rendering any web content
,
Aug 30 2016
My cl in c#7 adjusts the toolbar height if the browser is in Material Design mode and it's running on a Retina device. However if I back out my change and run on my desktop (i.e. non-Retina device) I still see the problem. I'm not sure why I no longer saw it on my Retina machine when I backed out my cl (per my comment in c#11), but still seeing it on my non-Retina machine means this jitteriness predates my cl from c#7. That said, in a prior cl I changed the height of the toolbar from 35pt to 37pt for Material Design - my thought was perhaps this is a regression caused by that change. And before that I made a different change to the toolbar height code which landed on 2/25/16 (just before the M50 branch point). This was https://codereview.chromium.org/1722883002/. However, I can reproduce this jitteriness in M49 (49.0.2623.112) which predates all of my changes, and even predates the Chrome flag that lets you toggle Material Design mode (the Settings page code also watches that flag). I don't know how much further back this issue goes, but it's not from any Material Design change I've made. Leaving assigned to dbeam@.
,
Aug 30 2016
removing -M-54 if it's happening in Chrome 49 for you, shrike@
,
Jul 6 2017
I'm no longer working on Chrome, and unlikely to fix any bug I'm currently assigned. So this bug doesn't languish, I'm unassigning myself.
,
Jul 28 2017
Bulk edit, marking "Assigned" bugs with no owner to "Available".
,
Jul 30
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 1
This issue is referring to an old (pre-M59) Settings UI. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mni...@etouch.net
, Aug 25 2016