New issue
Advanced search Search tips

Issue 640879 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

"Failing step" drop down doesn't drop down

Project Member Reported by jparent@chromium.org, Aug 25 2016

Issue description

Not sure what is supposed to happen,but, when I click on the "Failing step" drop down on an examine page, nothing drops down, nothing happens ...
 
Labels: -Pri-2 Pri-1
Status: Available (was: Untriaged)
Looks like a recent regression. 
Owner: seanmccullough@chromium.org
Status: Started (was: Available)
Ah, this was broken by https://chromium-review.googlesource.com/c/374719/

I think I have a fix for this. We need integration testing!
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/77d46889371d80147d9092789d0fc73372bd65c8

commit 77d46889371d80147d9092789d0fc73372bd65c8
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Thu Aug 25 18:52:18 2016

[som] Fix some frontend tests and code broken by the reasons refactoring.

In the future we need to be more careful about making sure that changes
to the JSON format are tested on the client and don't break things there.
The example alerts in test/alerts-data.js should be updated whenever we
make changes to alerts-dispatcher that alter the structure of the json it
produces.

BUG= 640879 

Change-Id: Ie515ad81bcfe7fdc3ab1a48d515fff176be0c0a6
Reviewed-on: https://chromium-review.googlesource.com/376100
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/77d46889371d80147d9092789d0fc73372bd65c8/go/src/infra/appengine/sheriff-o-matic/elements/som-examine.html
[modify] https://crrev.com/77d46889371d80147d9092789d0fc73372bd65c8/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html
[modify] https://crrev.com/77d46889371d80147d9092789d0fc73372bd65c8/go/src/infra/appengine/sheriff-o-matic/test/alerts-data.js
[modify] https://crrev.com/77d46889371d80147d9092789d0fc73372bd65c8/go/src/infra/appengine/sheriff-o-matic/test/som-examine-test.html
[modify] https://crrev.com/77d46889371d80147d9092789d0fc73372bd65c8/go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html

Status: Fixed (was: Started)

Sign in to add a comment