New issue
Advanced search Search tips

Issue 640869 link

Starred by 3 users
Status: Fixed
Owner:
kojii@chromium.org
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 583711



Sign in to add a comment

Stack overflow when there are a lot of 2 or more spaces in a row

Project Member Reported by kojii@chromium.org, Aug 25 2016 
It looks like tail recursion is not applied as we expect in adjustMidpointsAndAppendRunsForObjectIfNeeded().
long-line-stack-overflow.html
260 bytes View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/775f244f3b549c5887adc6d945656f52685d800c

commit 775f244f3b549c5887adc6d945656f52685d800c
Author: kojii <kojii@chromium.org>
Date: Thu Aug 25 18:48:13 2016

Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded

Somehow VS2015 does not apply tail-recursion, and hits stack overflow
even in official build. Crashes were reported on CrOS too.

This patch changes it to loop.

No behavior changes.

BUG=583711,  640869 

Review-Url: https://codereview.chromium.org/2267363007
Cr-Commit-Position: refs/heads/master@{#414491}

[modify] https://crrev.com/775f244f3b549c5887adc6d945656f52685d800c/third_party/WebKit/Source/core/layout/line/InlineIterator.h

Comment 2 by e...@chromium.org, Aug 26 2016

Status: Fixed (was: Assigned)

Comment 3 by kojii@chromium.org, Dec 1 2016 

Issue 668361 has been merged into this issue.
►

Sign in to add a comment