New issue
Advanced search Search tips

Issue 640863 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Site Engagement should be available in incognito mode.

Project Member Reported by calamity@chromium.org, Aug 25 2016

Issue description

Some clients of the engagement service need to behave sanely in incognito which currently doesn't have an engagement service. We should implement a 'copy-on-write' version of engagement that reads values from the original profile and then maintains its own copy once modified.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c83f6df5af844d8934d62231bbfc4b94c4b0898

commit 0c83f6df5af844d8934d62231bbfc4b94c4b0898
Author: calamity <calamity@chromium.org>
Date: Tue Aug 30 05:46:26 2016

Enable site engagement in incognito.

This CL makes the SiteEngagementService available in incognito. When in
incognito mode, the service will initialize values from the original
profile and then subsequently maintain its own independent copy.

Incognito profiles will not record periodic metrics.

BUG= 640863 
TBR=dbeam@chromium.org,rdevlin.cronin@chromium.org,dtrainor@chromium.org

Review-Url: https://codereview.chromium.org/2274973003
Cr-Commit-Position: refs/heads/master@{#415177}

[modify] https://crrev.com/0c83f6df5af844d8934d62231bbfc4b94c4b0898/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/0c83f6df5af844d8934d62231bbfc4b94c4b0898/chrome/browser/engagement/site_engagement_helper.cc
[modify] https://crrev.com/0c83f6df5af844d8934d62231bbfc4b94c4b0898/chrome/browser/engagement/site_engagement_score.cc
[modify] https://crrev.com/0c83f6df5af844d8934d62231bbfc4b94c4b0898/chrome/browser/engagement/site_engagement_score.h
[modify] https://crrev.com/0c83f6df5af844d8934d62231bbfc4b94c4b0898/chrome/browser/engagement/site_engagement_service.cc
[modify] https://crrev.com/0c83f6df5af844d8934d62231bbfc4b94c4b0898/chrome/browser/engagement/site_engagement_service.h
[modify] https://crrev.com/0c83f6df5af844d8934d62231bbfc4b94c4b0898/chrome/browser/engagement/site_engagement_service_factory.cc
[modify] https://crrev.com/0c83f6df5af844d8934d62231bbfc4b94c4b0898/chrome/browser/engagement/site_engagement_service_factory.h
[modify] https://crrev.com/0c83f6df5af844d8934d62231bbfc4b94c4b0898/chrome/browser/engagement/site_engagement_service_unittest.cc
[modify] https://crrev.com/0c83f6df5af844d8934d62231bbfc4b94c4b0898/chrome/browser/ui/extensions/application_launch.cc
[modify] https://crrev.com/0c83f6df5af844d8934d62231bbfc4b94c4b0898/chrome/browser/ui/webui/engagement/site_engagement_ui.cc

Status: Fixed (was: Started)
Components: -Security>UX Internals>Permissions>SiteEngagement

Sign in to add a comment