New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640862 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"MaterialHistoryBrowserTest.HistoryListTest" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 25 2016

Issue description

"MaterialHistoryBrowserTest.HistoryListTest" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 21 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipNYXRlcmlhbEhpc3RvcnlCcm93c2VyVGVzdC5IaXN0b3J5TGlzdFRlc3QM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: -Sheriff-Chromium
Owner: calamity@chromium.org
Status: Assigned (was: Untriaged)
Chris: this error is in a test you added in commit cb8aa76 at "2016-08-24 11:51:34".  Can you please investigate?  If you can't find the error in the next 30 minutes please disable test or revert CL.  Thanks.

Commit:
https://chromium.googlesource.com/chromium/src/+/cb8aa763196dbb73c7aa724bd3bc7374a2a540a7

Error:
AssertionError: expected true to be false
    at Function.assert.isFalse (chai.js:2459:31)
    at assertFalse (test_api.js:860:17)
    at history_list_test.js:308:11

Test line:
https://cs.chromium.org/chromium/src/chrome/test/data/webui/md_history/history_list_test.js?rcl=0&l=308

in test 'scrolling history list causes toolbar shadow to appear'.


Project Member

Comment 2 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62514ae903a294ca3f3075b0f8c452d53d02da0a

commit 62514ae903a294ca3f3075b0f8c452d53d02da0a
Author: calamity <calamity@chromium.org>
Date: Fri Aug 26 08:46:56 2016

[MD History] Disable toolbar shadow test.

This CL disables the toolbar shadow test because it's flaky. This will be
reenabled after investigation.

BUG= 640862 

Review-Url: https://codereview.chromium.org/2271583009
Cr-Commit-Position: refs/heads/master@{#414673}

[modify] https://crrev.com/62514ae903a294ca3f3075b0f8c452d53d02da0a/chrome/test/data/webui/md_history/history_list_test.js

Project Member

Comment 3 by chromium...@appspot.gserviceaccount.com, Oct 29 2016

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "MaterialHistoryBrowserTest.HistoryListTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipNYXRlcmlhbEhpc3RvcnlCcm93c2VyVGVzdC5IaXN0b3J5TGlzdFRlc3QM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, Oct 30 2016

Detected 3 new flakes for test/step "MaterialHistoryBrowserTest.HistoryListTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipNYXRlcmlhbEhpc3RvcnlCcm93c2VyVGVzdC5IaXN0b3J5TGlzdFRlc3QM. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f967bf2701c41f0f074e3ea2b664d73a0085125b

commit f967bf2701c41f0f074e3ea2b664d73a0085125b
Author: xidachen <xidachen@chromium.org>
Date: Mon Oct 31 13:42:03 2016

Disable MaterialHistoryBrowserTest.HistoryListTest since

New flakes detected on chromeos

BUG= 640862 
TBR=calamity@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2459263003
Cr-Commit-Position: refs/heads/master@{#428698}

[modify] https://crrev.com/f967bf2701c41f0f074e3ea2b664d73a0085125b/chrome/test/data/webui/md_history/md_history_browsertest.js

Labels: -Sheriff-Chromium
Hi Sheriff here,

The MaterialHistoryBrowserTest.SyncedTabsTest fails on Mac, will disable it, please investigate and re-enable.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53f02e124e3a0369a7fb3724fda80f614887e373

commit 53f02e124e3a0369a7fb3724fda80f614887e373
Author: xidachen <xidachen@chromium.org>
Date: Mon Oct 31 14:08:32 2016

Disable MaterialHistoryBrowserTest.SyncedTabsTest

It fails on Mac

BUG= 640862 
TBR=calamity@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2459383002
Cr-Commit-Position: refs/heads/master@{#428701}

[modify] https://crrev.com/53f02e124e3a0369a7fb3724fda80f614887e373/chrome/test/data/webui/md_history/md_history_browsertest.js

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e31e1d7de8773afa0f5b5a2fa7b43e05ab9c3eb6

commit e31e1d7de8773afa0f5b5a2fa7b43e05ab9c3eb6
Author: calamity <calamity@chromium.org>
Date: Wed Nov 02 02:52:48 2016

Revert of Disable MaterialHistoryBrowserTest.HistoryListTest since (patchset #1 id:1 of https://codereview.chromium.org/2459263003/ )

Reason for revert:
Looks like this was a skia misconfig that was causing too much output.

Original issue's description:
> Disable MaterialHistoryBrowserTest.HistoryListTest since
>
> New flakes detected on chromeos
>
> BUG= 640862 
> TBR=calamity@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/f967bf2701c41f0f074e3ea2b664d73a0085125b
> Cr-Commit-Position: refs/heads/master@{#428698}

TBR=xidachen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 640862 

Review-Url: https://codereview.chromium.org/2466263005
Cr-Commit-Position: refs/heads/master@{#429192}

[modify] https://crrev.com/e31e1d7de8773afa0f5b5a2fa7b43e05ab9c3eb6/chrome/test/data/webui/md_history/md_history_browsertest.js

Cc: tsergeant@chromium.org
Components: UI>Browser>History
Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd157d9a5f102bb94928e7a2be61250e2ff43826

commit dd157d9a5f102bb94928e7a2be61250e2ff43826
Author: calamity <calamity@chromium.org>
Date: Fri Dec 16 07:05:32 2016

[MD History] Reenable SyncedTabsTest.

This CL skips the focus test that is likely the cause of failures and
reenables the test on all platforms.

BUG= 640862 

Review-Url: https://codereview.chromium.org/2582543005
Cr-Commit-Position: refs/heads/master@{#439056}

[modify] https://crrev.com/dd157d9a5f102bb94928e7a2be61250e2ff43826/chrome/test/data/webui/md_history/history_synced_tabs_test.js
[modify] https://crrev.com/dd157d9a5f102bb94928e7a2be61250e2ff43826/chrome/test/data/webui/md_history/md_history_browsertest.js

Status: Fixed (was: Assigned)
Flakes seem gone. Reopen if this is still an issue.

Sign in to add a comment