Issue metadata
Sign in to add a comment
|
Page Info on Views: use standard close button. |
||||||||||||||||||||||||||
Issue descriptionBubbleDialogDelegateView::ShouldShowCloseButton Suggested by msw@ at https://codereview.chromium.org/2278513003
,
Sep 6 2016
,
Oct 18 2016
,
Oct 19 2016
,
Oct 20 2016
,
Oct 28 2016
Either this bug or Issue 660230 needs to be fixed for M55 in order to pass Accessibility Review for Material Page Info (Issue 650420). I tried a quick fix for this, but I ended up with extra vertical whitespace. Need to look at permission bubbles to see how they avoid the whitespace.
,
Nov 3 2016
lgarron - assigning to you but feel free to re-assign if needed.
,
Nov 8 2016
Since MacViews isn't shipping on Mac, Issue 660230 is P3.
,
Nov 16 2016
,
Nov 23 2016
,
Dec 14 2016
Merging into Issue 674269 since it has pretty pictures :)
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37240b4fdef1ec7017f59d4cb7ced8c655e5c595 commit 37240b4fdef1ec7017f59d4cb7ced8c655e5c595 Author: tapted <tapted@chromium.org> Date: Wed Jan 11 03:33:37 2017 PageInfo bubble: Use the non-client view's window title and close button. Currently it sets a custom close button which is different to the other Harmony dialogs. To keep items aligned, use the standard panel margins from ui/views/layout_constants.h. (13px rather than 16px). This makes the panel slightly more narrow. BUG= 640851 , 674269 Review-Url: https://codereview.chromium.org/2581493002 Cr-Commit-Position: refs/heads/master@{#442779} [modify] https://crrev.com/37240b4fdef1ec7017f59d4cb7ced8c655e5c595/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc [modify] https://crrev.com/37240b4fdef1ec7017f59d4cb7ced8c655e5c595/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
,
Feb 10 2017
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Sep 1 2016Labels: Hotlist-GoodFirstBug