New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640851 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 674269
Owner: ----
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug
Team-Security-UX

Blocked on:
issue 571526

Blocking:
issue 571533
issue 650420



Sign in to add a comment

Page Info on Views: use standard close button.

Project Member Reported by lgar...@chromium.org, Aug 25 2016

Issue description

BubbleDialogDelegateView::ShouldShowCloseButton

Suggested by msw@ at https://codereview.chromium.org/2278513003
 
Components: Security>UX
Labels: Hotlist-GoodFirstBug
Labels: PageInfo
Labels: Hotlist-PageInfo
Components: UI>Browser>Omnibox>PageInfo
Components: -UI>Browser>Omnibox>PageInfo UI>Browser>Bubbles>PageInfo
Blocking: 650420
Labels: -Pri-3 Pri-1
Either this bug or  Issue 660230  needs to be fixed for M55 in order to pass Accessibility Review for Material Page Info (Issue 650420).

I tried a quick fix for this, but I ended up with extra vertical whitespace. Need to look at permission bubbles to see how they avoid the whitespace.
Cc: -lgar...@chromium.org
Owner: lgar...@chromium.org
lgarron - assigning to you but feel free to re-assign if needed.
Cc: lgar...@chromium.org
Labels: -Pri-1 Hotlist-Enamel-FinishAllTheThings Pri-3
Owner: ----
Since MacViews isn't shipping on Mac,  Issue 660230  is P3.
Labels: -Hotlist-PageInfo -PageInfo
Components: -Security>UX
Mergedinto: 674269
Status: Duplicate (was: Available)
Merging into  Issue 674269  since it has pretty pictures :)
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37240b4fdef1ec7017f59d4cb7ced8c655e5c595

commit 37240b4fdef1ec7017f59d4cb7ced8c655e5c595
Author: tapted <tapted@chromium.org>
Date: Wed Jan 11 03:33:37 2017

PageInfo bubble: Use the non-client view's window title and close button.

Currently it sets a custom close button which is different to the other
Harmony dialogs.

To keep items aligned, use the standard panel margins from
ui/views/layout_constants.h. (13px rather than 16px). This makes the
panel slightly more narrow.

BUG= 640851 ,  674269 

Review-Url: https://codereview.chromium.org/2581493002
Cr-Commit-Position: refs/heads/master@{#442779}

[modify] https://crrev.com/37240b4fdef1ec7017f59d4cb7ced8c655e5c595/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
[modify] https://crrev.com/37240b4fdef1ec7017f59d4cb7ced8c655e5c595/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

Blockedon: 571526

Sign in to add a comment