New issue
Advanced search Search tips

Issue 640837 link

Starred by 2 users
Status: Fixed
Owner:
rdevlin....@chromium.org
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

ExtensionMsg_Loaded_Params are quite broken

Project Member Reported by rdevlin....@chromium.org, Aug 25 2016 
The ExtensionMsg_Loaded_Params fails to actually pass either the |id| or the |tab_specific_permissions| field when it gets pickled over IPC.

Additionally, we don't use the id field when creating the extension, even though we probably should - this would save us some work in the construction of the extension, as well as ensuring that test extensions (which may not have a specified path or key) have the same id in the renderer as in the browser.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b3723bc43398ea016a3d109430492784b2be234

commit 2b3723bc43398ea016a3d109430492784b2be234
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Fri Aug 26 00:36:18 2016

[Extensions] Fix ExtensionMsg_Loaded_Params

The ExtensionMsg_Loaded_Params had a number of issues:
- it never pickled the id
- it never pickled the tab specific permissions
- it didn't use the explicit id when constructing the extension

The latter is useful to safe work in the normal case, and important in
tests since test extensions may not have keys or paths.

BUG= 640837 

Review-Url: https://codereview.chromium.org/2279013002
Cr-Commit-Position: refs/heads/master@{#414600}

[modify] https://crrev.com/2b3723bc43398ea016a3d109430492784b2be234/extensions/common/OWNERS
[modify] https://crrev.com/2b3723bc43398ea016a3d109430492784b2be234/extensions/common/extension_messages.cc
[add] https://crrev.com/2b3723bc43398ea016a3d109430492784b2be234/extensions/common/extension_messages_unittest.cc
[modify] https://crrev.com/2b3723bc43398ea016a3d109430492784b2be234/extensions/extensions_tests.gypi

Comment 2 by rdevlin....@chromium.org, Aug 26 2016

Status: Fixed (was: Started)
►

Sign in to add a comment