Move policy generated files broke the chromeos build |
|||||
Issue descriptionMoving policy generated filed broke the chromeos build. See log: https://build.chromium.org/p/chromiumos.chromium/builders/x86-generic-tot-chromium-pfq-informational/builds/9462/steps/BuildPackages/logs/stdio chromeos-chrome-54.0.2839.0_alpha-r1: /usr/bin/install: cannot stat '/var/cache/chromeos-chrome/chrome-src/src/out_x86-generic/Release/gen/policy/cloud_policy.proto': No such file or directory chromeos-chrome-54.0.2839.0_alpha-r1: !!! doins: /var/cache/chromeos-chrome/chrome-src/src/out_x86-generic/Release/gen/policy/cloud_policy.proto does not exist chromeos-chrome-54.0.2839.0_alpha-r1: * ERROR: chromeos-base/chromeos-chrome-54.0.2839.0_alpha-r1::chromiumos failed (install phase): chromeos-chrome-54.0.2839.0_alpha-r1: * doins failed This is caused by the change of this cl of brettw@: https://codereview.chromium.org/2273783002/ However, in: src/third_party/chromiumos-overlay/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild We explicitly install cloud_policy.proto there from a fixed location. The correct thing to do is to find it in gen/policy and copy it. This is going to fail our PFQ.
,
Aug 25 2016
Right. The challenge is that the ebuild is part of chromeos which is not necessarily 100% in sync with the chrome repo. We already have a special case for GN vs GYP (which we could deprecate) but the robust way to do this would be to find the file in gen/ and copy that. We should also move that to deploy_chrome, but we can make that a TODO item.
,
Aug 25 2016
Issue 640896 has been merged into this issue.
,
Aug 25 2016
I added a new case to copy from the new location: https://chromium-review.googlesource.com/#/c/375661/ https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2fcdfd807d78a96b3871e499cf915e89d09a6a88 But it cares only GN case (I could not build CrOS Chrome with GYP... can we do today?)
,
Aug 25 2016
We no longer support GYP for Chrome on Chrome OS (or any other platform at this point I believe). After the next branch point we will be aggressively removing chrome GYP files.
,
Aug 25 2016
That fix looks fine, I will test locally but I expect the bots will cycle green.
,
Aug 25 2016
,
Aug 29 2016
,
Aug 29 2016
bulk verified
,
Aug 29 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by brettw@chromium.org
, Aug 25 2016