You can see this in the console when remote debugging: > 'window.postMessage(message, transferables, targetOrigin)' is deprecated and will be removed in M54, around October 2016. Please use 'window.postMessage(message, targetOrigin, transferables)' instead. See https://www.chromestatus.com/features/5719033043222528 for more details. Details: https://developers.google.com/web/updates/2016/06/chrome-52-deprecations#deprecate-overload-of-postmessage See use in https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js?q=ExtensionServerClient+file:%5Esrc/third_party/WebKit/Source/devtools/front_end/&sq=package:chromium&dr=C&l=859 Our only use of this method signature is in extensionserver, afaik. It appears the suggested method signature has been supported for a while, so we can switch today and it'll be fine everywhere.
this is gonna get nuked in the next day or so https://codereview.chromium.org/2295863002/ also foolip plans on merging the removal back to m54 so we gotta fix this asap.
Ah. fixed in https://codereview.chromium.org/2295863002/ Thanks philip!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77a58a92f789f4fd7099b2b4ff87cad27eea3067 commit 77a58a92f789f4fd7099b2b4ff87cad27eea3067 Author: foolip <foolip@chromium.org> Date: Wed Sep 07 21:56:44 2016 Remove window.postMessage(message, transferables, targetOrigin) legacy overload Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/h4ooaB_Y9JE/nh7vXshGBwAJ BUG= 425896 , 640825 R=sigbjornf@opera.com,haraken@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2295863002 Cr-Commit-Position: refs/heads/master@{#417066} [modify] https://crrev.com/77a58a92f789f4fd7099b2b4ff87cad27eea3067/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js [modify] https://crrev.com/77a58a92f789f4fd7099b2b4ff87cad27eea3067/chrome/third_party/chromevox/chromevox/injected/mathjax.js [modify] https://crrev.com/77a58a92f789f4fd7099b2b4ff87cad27eea3067/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt [modify] https://crrev.com/77a58a92f789f4fd7099b2b4ff87cad27eea3067/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args.html [modify] https://crrev.com/77a58a92f789f4fd7099b2b4ff87cad27eea3067/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp [modify] https://crrev.com/77a58a92f789f4fd7099b2b4ff87cad27eea3067/third_party/WebKit/Source/core/frame/Deprecation.cpp [modify] https://crrev.com/77a58a92f789f4fd7099b2b4ff87cad27eea3067/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/77a58a92f789f4fd7099b2b4ff87cad27eea3067/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48caa2cebaf1723dcfd8665e4859d90e2b55f2a2 commit 48caa2cebaf1723dcfd8665e4859d90e2b55f2a2 Author: Philip Jägenstedt <foolip@chromium.org> Date: Tue Sep 13 09:10:15 2016 Remove window.postMessage(message, transferables, targetOrigin) legacy overload Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/h4ooaB_Y9JE/nh7vXshGBwAJ BUG= 425896 , 640825 R=sigbjornf@opera.com,haraken@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2295863002 Cr-Commit-Position: refs/heads/master@{#417066} (cherry picked from commit 77a58a92f789f4fd7099b2b4ff87cad27eea3067) Review URL: https://codereview.chromium.org/2336133002 . Cr-Commit-Position: refs/branch-heads/2840@{#322} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/48caa2cebaf1723dcfd8665e4859d90e2b55f2a2/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js [modify] https://crrev.com/48caa2cebaf1723dcfd8665e4859d90e2b55f2a2/chrome/third_party/chromevox/chromevox/injected/mathjax.js [modify] https://crrev.com/48caa2cebaf1723dcfd8665e4859d90e2b55f2a2/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt [modify] https://crrev.com/48caa2cebaf1723dcfd8665e4859d90e2b55f2a2/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args.html [modify] https://crrev.com/48caa2cebaf1723dcfd8665e4859d90e2b55f2a2/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp [modify] https://crrev.com/48caa2cebaf1723dcfd8665e4859d90e2b55f2a2/third_party/WebKit/Source/core/frame/Deprecation.cpp [modify] https://crrev.com/48caa2cebaf1723dcfd8665e4859d90e2b55f2a2/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/48caa2cebaf1723dcfd8665e4859d90e2b55f2a2/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a91dd1d7611e879f8d03bf533c45fa229ed7246d commit a91dd1d7611e879f8d03bf533c45fa229ed7246d Author: foolip <foolip@chromium.org> Date: Tue Sep 13 11:39:27 2016 Restore replacedWillBeRemoved to fix compile after postMessage changes It is still in use on the M54 branch (2840) but wasn't on master. This can't be landed on master and backported, precisely because it is unused, which causes a warning, and -Werror is enabled. BUG= 425896 , 640825 TBR=sigbjornf@opera.com,haraken@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2331293004 Cr-Commit-Position: refs/branch-heads/2840@{#325} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a91dd1d7611e879f8d03bf533c45fa229ed7246d/third_party/WebKit/Source/core/frame/Deprecation.cpp
Comment 1 by paulir...@chromium.org
, Sep 2 2016