arc: Stop piggybacking "text input started" and "show virtual keyboard" event |
|||||||||
Issue descriptionInternal bug: b/31001453. Let's remove the following if-block marked as TODO. https://chromium.googlesource.com/chromium/src/+/master/components/arc/ime/arc_ime_service.cc#145 input_method->OnTextInputTypeChanged(this); // TODO(crbug.com/581282): Remove this piggyback call when // ImeInstance::ShowImeIfNeeded is wired to ARC. if (input_method->GetTextInputClient() == this && ime_type_ != ui::TEXT_INPUT_TYPE_NONE) { input_method->ShowImeIfNeeded(); } On Android IMF these two are conceptually distinct, and some apps like Hangouts takes this liberty. The above code is not just unnecessary now but also being an obstacle to make such apps work better b/31001453.
,
Aug 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17a7a0c83e3615a6f8ad9d56e4b82006b53660ff commit 17a7a0c83e3615a6f8ad9d56e4b82006b53660ff Author: kinaba <kinaba@chromium.org> Date: Thu Aug 25 03:11:59 2016 arc: Stop piggybacking "text input started" and "show virtual keyboard" events. It is not only useless in the latest version, but is even harmful for some advanced apps that take the liberty of splitting these two events. This change itself should not change any observable behavior yet, but will be necessary to enable coming Android-side change to make this split effective. BUG= 640816 BUG=b/31001453 TEST=ArcImeServiceTest TEST=Tested manually with some ARC apps (Settings, PlayStore) Review-Url: https://codereview.chromium.org/2280503002 Cr-Commit-Position: refs/heads/master@{#414283} [modify] https://crrev.com/17a7a0c83e3615a6f8ad9d56e4b82006b53660ff/components/arc/ime/arc_ime_service.cc [modify] https://crrev.com/17a7a0c83e3615a6f8ad9d56e4b82006b53660ff/components/arc/ime/arc_ime_service_unittest.cc
,
Aug 26 2016
Sorry for the last minute merge-request, but I hope the change is * very same to merge: it only affects ARC apps in Chrome OS in tablet mode. * has an impact on some popular ARC apps (notably Hangouts)
,
Aug 26 2016
[Automated comment] Less than 2 weeks to go before stable on M53, manual review required.
,
Aug 31 2016
Internal bug punted to M54. Closing
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by kinaba@chromium.org
, Aug 24 2016